libopendkim/tests: fix t-test205 expected return value - #330
Merged
thegushi merged 1 commit intoMay 24, 2026
Conversation
dkim_eom() returns the status of the best signature, not the worst. When Ed25519 passes and RSA is corrupted, the return is DKIM_STAT_OK because a valid signature was found. The per-sig checks via dkim_getsiglist() are the correct way to confirm RSA failed and Ed25519 passed.
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dkim_eom()returns the status of the best (first passing) signature, not the worst — when Ed25519 passes and RSA is corrupted, the return isDKIM_STAT_OKdkim_getsiglist()/DKIM_SIG_CHECK()below that assertion are the correct way to confirm RSA failed and Ed25519 passed independentlyThe PR description for #326 incorrectly stated that
dkim_eom()returnsDKIM_STAT_BADSIGwhen any signature fails; this corrects both the code and that misunderstanding.Test plan
gmake checksuite passes (all 160+ unit tests + miltertest integration suite)