[Improvements]: Add memzero wrapper #2395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Milerius
changed the title
Milerius
force-pushed
the
m/memzero_wrapper
branch
from
e415205 to
3c03f1e
Compare
optout21
approved these changes
Jul 21, 2022
hewigovens
approved these changes
Jul 21, 2022
Contributor
hewigovens
left a comment
hewigovens
left a comment
There was a problem hiding this comment.
Looks good, do we only use memset / memzero in HDWallet? I thought might be somewhere else too
Contributor
Author
Let's do it incrementally when we modify a file and we find a memzero/memset, use the new wrapper |
DeanDonkov
pushed a commit
to changex-app/wallet-core
that referenced
this pull request
Apr 7, 2023
* feat(memzero): add memzero c++ wrapper * fix(memzero): fix cmake * feat(hdwallet): use memzero wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to test
run C++ unit tests
Types of changes
Checklist