Rename Binance to BNB #662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolya182
reviewed
Sep 24, 2019
| | 501 | Solana | SOL | <img src="https://raw.githubusercontent.com/trustwallet/assets/master/blockchains/solana/info/logo.png" width="32" /> | <https://solana.com> | | ||
| | 700 | xDai | xDAI | <img src="https://raw.githubusercontent.com/trustwallet/assets/master/blockchains/xdai/info/logo.png" width="32" /> | <https://poa.network/xdai> | | ||
| | 714 | Binance | BNB | <img src="https://raw.githubusercontent.com/trustwallet/assets/master/blockchains/binance/info/logo.png" width="32" /> | <https://binance.org> | | ||
| | 714 | BNB | BNB | <img src="https://raw.githubusercontent.com/trustwallet/assets/master/blockchains/binance/info/logo.png" width="32" /> | <https://binance.org> | |
Contributor
There was a problem hiding this comment.
Suggested change
| | 714 | BNB | BNB | <img src="https://raw.githubusercontent.com/trustwallet/assets/master/blockchains/binance/info/logo.png" width="32" /> | <https://binance.org> | | |
| | 714 | BNB | BNB | <img src="https://raw.githubusercontent.com/trustwallet/assets/master/blockchains/bnb/info/logo.png" width="32" /> | <https://binance.org> | |
Changes made here trustwallet/assets#270
Contributor
Author
There was a problem hiding this comment.
damn, this needs to change codegen
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
=====================================
Coverage 85% 85%
=====================================
Files 289 289
Lines 7076 7076
=====================================
Hits 6015 6015
Misses 1061 1061
Continue to review full report at Codecov.
|
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.