fix(store): publish lock ownership atomically - #88
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new stale-lock cleanup can delete malformed-but-non-empty lock contents, which can allow a live lock to be stolen under partial/truncated content scenarios.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR hardens ReducerBackedStore’s file lock protocol so that lock ownership is published atomically (preventing a second writer from “stealing” an empty lock inode during initialization), and adds a deterministic regression test to cover the persistence race.
Changes:
- Reworks lock acquisition to write an owner record to a candidate file and atomically “publish” it via
linkSync, and updates unlock to verify ownership before removing the lock. - Updates lock parsing to accept both legacy
pidand newpid:uuidformats. - Adds a deterministic test (
AUD-10) ensuring an empty live lock can’t be replaced or entered by a second writer.
File summaries
| File | Description |
|---|---|
src/reducer-backed-store.ts |
Implements atomic lock-owner publication via hard-linking and owner-verified unlock semantics. |
test/reducer-backed-store.test.ts |
Adds deterministic coverage for the “empty live lock cannot be stolen” race scenario. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Stack
1 of 6. Merge before the execution-identity authority PR.