Skip to content

fix(portal): show Company Forms section even when all tasks are compl…#2334

Merged
Marfuen merged 1 commit intomainfrom
mariano/cs-183-bug-employee-portal-if-device-agent-policies-signed-and
Mar 18, 2026
Merged

fix(portal): show Company Forms section even when all tasks are compl…#2334
Marfuen merged 1 commit intomainfrom
mariano/cs-183-bug-employee-portal-if-device-agent-policies-signed-and

Conversation

@Marfuen
Copy link
Contributor

@Marfuen Marfuen commented Mar 18, 2026

…eted

The early return when allCompleted was true prevented Whistleblower Reports and Access Requests from rendering. Changed to conditional render so Company Forms always appears when enabled.

Closes CS-183

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes COMP-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

…eted

The early return when allCompleted was true prevented Whistleblower Reports
and Access Requests from rendering. Changed to conditional render so
Company Forms always appears when enabled.

Closes CS-183

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@cursor
Copy link

cursor bot commented Mar 18, 2026

PR Summary

Low Risk
Low risk UI-only change that removes an early return; main risk is minor layout/regression in the completed-state view.

Overview
Fixes the employee home view so the Company Forms section still renders after all required tasks are completed.

EmployeeTasksList replaces the early return for the "You're all set!" state with conditional rendering, ensuring the completion card or the tasks/progress UI shows, while the forms list (including Whistleblower Reports and Access Requests when enabled) always appears below.

Written by Cursor Bugbot for commit 7f833a0. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-api-test Building Building Preview, Comment Mar 18, 2026 5:28pm
portal Building Building Preview, Comment Mar 18, 2026 5:28pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
app Skipped Skipped Mar 18, 2026 5:28pm

Request Review

@Marfuen Marfuen merged commit 5661cd6 into main Mar 18, 2026
7 of 9 checks passed
@Marfuen Marfuen deleted the mariano/cs-183-bug-employee-portal-if-device-agent-policies-signed-and branch March 18, 2026 17:28
claudfuen pushed a commit that referenced this pull request Mar 19, 2026
# [3.10.0](v3.9.0...v3.10.0) (2026-03-19)

### Bug Fixes

* **integrations:** filter GWS employee sync by organizational units ([#2336](#2336)) ([e3a9867](e3a9867))
* **portal:** show Company Forms section even when all tasks are completed ([#2334](#2334)) ([5661cd6](5661cd6))
* **vendors:** extract root domain from subdomain vendor websites ([#2337](#2337)) ([8c6865b](8c6865b))
* **vendors:** validate vendor research URLs belong to correct domain ([#2335](#2335)) ([37a9813](37a9813))

### Features

* **people:** add Agent Installed column and hide deactivated users by default ([#2331](#2331)) ([67041ab](67041ab))
@claudfuen
Copy link
Contributor

🎉 This PR is included in version 3.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants