Skip to content

[dev] [Marfuen] mariano/cs-169-bug-gws-syncing-incorrect-users#2336

Merged
Marfuen merged 2 commits intomainfrom
mariano/cs-169-bug-gws-syncing-incorrect-users
Mar 18, 2026
Merged

[dev] [Marfuen] mariano/cs-169-bug-gws-syncing-incorrect-users#2336
Marfuen merged 2 commits intomainfrom
mariano/cs-169-bug-gws-syncing-incorrect-users

Conversation

@github-actions
Copy link
Contributor

This is an automated pull request to merge mariano/cs-169-bug-gws-syncing-incorrect-users into dev.
It was created by the [Auto Pull Request] action.

Users in unselected OUs were being synced and reactivated because the
employee sync ignored the target_org_units setting. Now the same OU
filter used for security checks also applies to employee sync.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@linear
Copy link

linear bot commented Mar 18, 2026

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-api-test Ready Ready Preview, Comment Mar 18, 2026 6:32pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app Skipped Skipped Mar 18, 2026 6:32pm
portal Skipped Skipped Mar 18, 2026 6:32pm

Request Review

@cursor
Copy link

cursor bot commented Mar 18, 2026

PR Summary

Medium Risk
Changes the Google Workspace employee sync population and deactivation domain set based on configured OU paths, which can affect who gets imported/reactivated/deactivated if OU selection is misconfigured. Logic is straightforward and covered by new unit tests, but it impacts production sync behavior.

Overview
Adds an organizational unit (OU) filter to Google Workspace employee sync so only users in configured target_org_units (including child OUs, with exact-segment matching) are considered for subsequent include/exclude email filtering and downstream import/deactivation decisions.

Introduces reusable filterUsersByOrgUnits (with tests) and exposes the existing target_org_units variable in the Google Workspace manifest/UX copy as applying to both checks and employee sync, plus adds sync logging for OU filtering results.

Written by Cursor Bugbot for commit ab5921d. This will update automatically on new commits. Configure here.

@Marfuen Marfuen merged commit e3a9867 into main Mar 18, 2026
5 checks passed
@Marfuen Marfuen deleted the mariano/cs-169-bug-gws-syncing-incorrect-users branch March 18, 2026 18:30
@vercel vercel bot temporarily deployed to Preview – app March 18, 2026 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview – portal March 18, 2026 18:31 Inactive
claudfuen pushed a commit that referenced this pull request Mar 19, 2026
# [3.10.0](v3.9.0...v3.10.0) (2026-03-19)

### Bug Fixes

* **integrations:** filter GWS employee sync by organizational units ([#2336](#2336)) ([e3a9867](e3a9867))
* **portal:** show Company Forms section even when all tasks are completed ([#2334](#2334)) ([5661cd6](5661cd6))
* **vendors:** extract root domain from subdomain vendor websites ([#2337](#2337)) ([8c6865b](8c6865b))
* **vendors:** validate vendor research URLs belong to correct domain ([#2335](#2335)) ([37a9813](37a9813))

### Features

* **people:** add Agent Installed column and hide deactivated users by default ([#2331](#2331)) ([67041ab](67041ab))
@claudfuen
Copy link
Contributor

🎉 This PR is included in version 3.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants