Skip to content

CS-536 [BUG] Offboarding notification despite 'skip off boarding' selected#3299

Merged
tofikwest merged 2 commits into
mainfrom
chas/skip-offboarding-notification
Jun 29, 2026
Merged

CS-536 [BUG] Offboarding notification despite 'skip off boarding' selected#3299
tofikwest merged 2 commits into
mainfrom
chas/skip-offboarding-notification

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

This is an automated pull request to merge chas/skip-offboarding-notification into dev.
It was created by the [Auto Pull Request] action.


Summary by cubic

Fix offboarding notifications when "skip offboarding" is selected by clearing any existing offboardDate on removal. Addresses CS-536 to prevent scheduled offboarding actions from running.

  • Bug Fixes
    • Set offboardDate: null in deleteById when skipOffboarding is true.
    • Updated tests to assert offboardDate is cleared.

Written for commit 1c138fd. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-framework-editor Ready Ready Preview, Comment Jun 29, 2026 7:50pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app Skipped Skipped Jun 29, 2026 7:50pm
portal Skipped Skipped Jun 29, 2026 7:50pm

Request Review

@chasprowebdev chasprowebdev changed the title [dev] [chasprowebdev] chas/skip-offboarding-notification CS-536 [BUG] Offboarding notification despite 'skip off boarding' selected Jun 29, 2026
@linear

linear Bot commented Jun 29, 2026

Copy link
Copy Markdown

CS-536

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@vercel vercel Bot temporarily deployed to Preview – portal June 29, 2026 19:49 Inactive
@vercel vercel Bot temporarily deployed to Preview – app June 29, 2026 19:49 Inactive
@tofikwest tofikwest merged commit 7a462f9 into main Jun 29, 2026
11 checks passed
@tofikwest tofikwest deleted the chas/skip-offboarding-notification branch June 29, 2026 19:51
@claudfuen

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.93.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants