refactor(devices): right-align device-sync control with icon-only re-sync button#3385
Merged
Conversation
… button The sync-source select moves to the right end of its row (it's a setting, not the page subject), with the re-sync button snug beside it as an icon-only button — the select already names what's syncing, so the 'Sync now' text was redundant. aria-label + title keep it accessible; the connect-an-integration empty slot right-aligns too so the control doesn't jump sides between states. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TfDHFTwRgYxUoyyqGkHPDc
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…d-ago + primary icon button Inline row per Tofik's mockup: 'Synced Xh ago' muted text, compact provider select (label dropped — the provider name + refresh affordance identify the control), and the re-sync button in the brand primary color, icon-only. Connect-an-integration slot keeps its label. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TfDHFTwRgYxUoyyqGkHPDc
Contributor
|
🎉 This PR is included in version 3.100.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Devices-tab layout polish (requested by Tofik):
aria-label="Sync now"+titlekeep it accessible and tooltippedicon-lg(32px) to match the select trigger height exactlyTests
88/88 devices tests passing unchanged — the button's accessible name is preserved, so every existing
getByRole('button', { name: /Sync now/i })assertion still holds. Typecheck clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01TfDHFTwRgYxUoyyqGkHPDc
Summary by cubic
Right-aligns the Device sync control and refines it into a compact inline row with “Synced Xh ago”, the provider select, and an icon-only re-sync button. Keeps accessibility and prevents layout jumps between states.
size="icon-lg"button witharia-label="Sync now"andtitle.lastSyncAt.Written for commit 410b8fc. Summary will update on new commits.