[dev] [tofikwest] fix/browser-automation-liveview-2fa - #3519
Closed
github-actions[bot] wants to merge 3 commits into
Closed
[dev] [tofikwest] fix/browser-automation-liveview-2fa#3519github-actions[bot] wants to merge 3 commits into
github-actions[bot] wants to merge 3 commits into
Conversation
The connect flow only re-pointed the live view before the sign-in (after finding the form). Once the AI submitted and the vendor showed a 2FA prompt, the iframe stayed on the pre-submit login tab — so a user asked to enter their 2FA code was looking at an empty login form and couldn't. Re-emit the live view right after the sign-in attempt, at the same tab the classifier judged, so the take-over happens on the page the user actually sees. +test.
The connect session was created without a timeout, so it used the project's short default and Browserbase auto-ended it (~2 min) — killing the live view while a user was still fetching their authenticator / entering a 2FA code (the 'Debugging connection was closed' notice). Give human-facing sessions an explicit 15-minute timeout; headless capture runs keep the short default. +tests.
Vendors like GitHub default the 2FA step to a passkey / security-key prompt (github.com/sessions/two-factor/webauthn) — which we can't use and which has no 6-digit field, so the panel said 'enter the code' while the page showed no place to type it. After sign-in, best-effort switch to the authenticator-app option (More options -> Use authenticator app / Enter a code) so the code field is actually shown — for us to fill a stored code, or for the user to type one during take-over. +test.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge fix/browser-automation-liveview-2fa into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Fixes connect live view and 2FA flows: the live view now follows to the 2FA page, sessions stay alive during take-overs, and passkey prompts are switched to code entry when needed.
Written for commit 7ecfb9f. Summary will update on new commits.