Lewis/lp gate - #30
Merged
Merged
Conversation
- Changed the redirect behavior for unauthenticated users to use the `sendTo` function instead of a direct URL redirect to the sign-in path. - This modification enhances the proxy's handling of user access based on authentication status.
- Updated the proxy to ensure that requests to the sign-in path do not trigger a redirect, maintaining user experience for unauthenticated users. - Adjusted the public access logic to streamline the handling of landing page visibility based on authentication status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes redirect loops around sign-in and tightens public route gating.
/sign-inalways passes through, and the landing page is public only when the marketing flag is on.Bug Fixes
/sign-into prevent loops and keep auth provider query params intact./sign-inis never the redirect target for signed-in or signed-out users.Refactors
PUBLIClist;isPublicnow only allows the landing page when marketing is enabled./sign-infromUNGATED; only/grant-accessand/everemain.Written for commit 73875f0. Summary will update on new commits.