Fix release image cleanup - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
image verification.
command.
commit.
Root cause
The release workflow tagged a digest-qualified pull as
lint-release-test:amd64, then passed both names to onedocker image rmcommand. Removing the local alias alsoremoved the local image record, so Docker reported the
digest-qualified name as absent and returned a nonzero status
after every verification command had already passed.
The runner is ephemeral, and later release steps use the
registry digest rather than the local AMD64 image. Removing
only the validation alias preserves the intended cleanup
without turning a successful verification into a failed job.
Validation
python3 tests/repository_test.pymake verifymake codecgit diff --checkThe signed
v0.1.5tag remains unchanged. After this lands,the release workflow can be dispatched from
mainagainstthat existing signed tag.
Written by Codex