fix(lume): run macos installer on vm queue - #2708
Merged
Merged
Conversation
injaneity
force-pushed
the
codex/fix-2670-macos-installer-queue
branch
from
July 31, 2026 03:12
b1d31d9 to
bc7b342
Compare
injaneity
marked this pull request as ready for review
July 31, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
DarwinVirtualizationService.installMacOSnow captures itsVirtualMachineHandleand dispatches installer construction, progress-observer registration, andinstallthrough the virtual machine's private queue. The progress observer stays alive until the install completion callback.why
Issue #2670 reports a
dispatch_assert_queuetrap inVZMacOSInstaller.init. The virtual machine is created with a private serial queue, but the installer was created in an unqualifiedTaskon the service's main actor. Virtualization requires installer setup on the virtual machine's queue.impact
lume createno longer constructsVZMacOSInstalleron the wrong queue after an IPSW download or local IPSW selection.validation
swift test --package-path libs/lume --filter VMVirtualizationServiceTestsgit diff --checkA live IPSW install was not run because this checkout has no prepared restore-image integration fixture. The package compile verifies the Swift 6 concurrency boundary, and the source change directly matches the framework queue assertion.