Skip to content

fix(lume): run macos installer on vm queue - #2708

Merged
f-trycua merged 1 commit into
mainfrom
codex/fix-2670-macos-installer-queue
Jul 31, 2026
Merged

fix(lume): run macos installer on vm queue#2708
f-trycua merged 1 commit into
mainfrom
codex/fix-2670-macos-installer-queue

Conversation

@injaneity

Copy link
Copy Markdown
Collaborator

what changed

DarwinVirtualizationService.installMacOS now captures its VirtualMachineHandle and dispatches installer construction, progress-observer registration, and install through the virtual machine's private queue. The progress observer stays alive until the install completion callback.

why

Issue #2670 reports a dispatch_assert_queue trap in VZMacOSInstaller.init. The virtual machine is created with a private serial queue, but the installer was created in an unqualified Task on the service's main actor. Virtualization requires installer setup on the virtual machine's queue.

impact

lume create no longer constructs VZMacOSInstaller on the wrong queue after an IPSW download or local IPSW selection.

validation

  • swift test --package-path libs/lume --filter VMVirtualizationServiceTests
  • result: build succeeded; 6 tests passed
  • git diff --check

A live IPSW install was not run because this checkout has no prepared restore-image integration fixture. The package compile verifies the Swift 6 concurrency boundary, and the source change directly matches the framework queue assertion.

@injaneity
injaneity force-pushed the codex/fix-2670-macos-installer-queue branch from b1d31d9 to bc7b342 Compare July 31, 2026 03:12
@injaneity
injaneity marked this pull request as ready for review July 31, 2026 10:50
@injaneity
injaneity requested a review from f-trycua as a code owner July 31, 2026 10:50

@f-trycua f-trycua left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at bc7b342. The installer is now created and started on the VZVirtualMachine serial queue, matching Apple’s queue contract and the surrounding service pattern. Focused tests and all required checks pass.

@f-trycua
f-trycua merged commit c4e150c into main Jul 31, 2026
10 checks passed
@f-trycua
f-trycua deleted the codex/fix-2670-macos-installer-queue branch July 31, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants