fix(cua-driver): prevent Linux uinput pointer panics - #2736
Merged
Conversation
f-trycua
marked this pull request as ready for review
July 31, 2026 22:27
added 2 commits
August 4, 2026 05:00
(cherry picked from commit be6d93b)
f-trycua
marked this pull request as draft
August 4, 2026 10:06
f-trycua
force-pushed
the
codex/fix-2715-linux-uinput-name
branch
from
August 4, 2026 10:06
be6d93b to
d9abbf6
Compare
f-trycua
marked this pull request as ready for review
August 4, 2026 12:28
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{"code":"uinput_unavailable"}instead of unwinding the worker or silently claiming fallback success/dev/uinputdevice on the hosted Linux runnerRoot cause
evdev 0.12 asserts during
VirtualDevice::buildwhen the supplied name exceeds its stricter limit. The name included a caller-controlled session/cursor identifier, so an overlong identifier unwound the Tokio blocking worker before the existing fallback could run. Device creation errors were otherwise swallowed by the XSendEvent fallback, which could report success despite the real-input route being unavailable.Validation
cargo fmt --package platform-linux -- --checkcargo test --locked -p platform-linux(16 host-runnable tests passed on macOS)d9abbf641962a2e667925892cca3bded70b78ca8The real-uinput CI step loads the hosted runner's
uinputmodule, grants access to the ephemeral device, and builds a pointer from an overlong multibyte name through the production function.Provenance
Salvaged from #2736's original bounded-name implementation; its source commit remains preserved through
cherry-pick -x. Reported and diagnosed by @marvinbaudach in #2715.Fixes #2715.