fix(cua-driver): keep Windows cursor visible without focus theft - #2864
Merged
Conversation
added 6 commits
August 4, 2026 18:41
f-trycua
marked this pull request as ready for review
August 5, 2026 01:34
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HWND_TOPMOST→HWND_NOTOPMOSTtransitionFixes #2802
Verification
cargo fmt --all -- --checkgit diff --checkcargo test -p platform-windows --lib— 41 passedcargo test -p cursor-overlay --lib— 42 passedcargo test -p cua-driver --test agent_cursor_windows_test— compiles on the local non-Windows host; 0 Windows-gated tests runcargo check --target x86_64-pc-windows-msvc -p cua-driver --test agent_cursor_windows_test— local cross-check cannot complete because the macOS host lacks Windows SDK/MSVC C headers required by transitive native dependencies; the canonical interactive Windows lane is the authoritative compile and behavior gateHosted Windows certification
4f1e63bbfbd7b22ac16c2d0559f6a4934e32d2bawindows-desktop-agent-cursor-px— PASS (Pixels, Focus, ZOrder, Cursor); proves visible un-targeted overlay at the top of the ordinary band, final non-topmost state, unchanged foreground and physical pointer, then target-bound placement between the WPF target and an independent Electron foreground window with target counter effect and no foreground leakwindows-desktop-agent-cursor-no-input-leak— PASS (Focus, ZOrder, Cursor, NoLeakedInput)2 passed; 0 failedresults.jsonlSHA-256:7ee13e3ea9dbfbade0be1303d440a657d724a27054cad72da295d1ac5e98123csummary.mdSHA-256:6d980c825c05c3a0bf3288f84d797e5f8c1e107066b1b76d43cfb9fb946c5dbaThe native lane's only failing cell was the unrelated existing
windows-webview2-left-click-px-background: UIA desktop enumeration exceeded its 2-second deadline and the action fell back toglobal_inputwhile that cell expectedaccessibility. That cell passed in the two preceding exact-head native runs (30963333853 and 30964551564); the final-head change only replaces the cursor test's target fixture. All 41 other final-run matrix cells, including both cursor cells, passed or produced their expected refusal.Standard PR checks are green, including the bounded Nix unit-test retry. The installer compatibility summary was still queued at the time this evidence was attached.
This PR remains draft for final audit; it has not been graduated or merged.