fix(cua-driver): ignore macOS compositor sibling surfaces - #2908
Merged
Conversation
f-trycua
force-pushed
the
codex/fix-macos-background-window-classification
branch
from
August 5, 2026 19:43
889844a to
9c48934
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2905.
Release certification evidence
The 0.18.0 exact-SHA canonical macOS run produced 28
same_pid_keyboard_ambiguityfailures across Electron, Tauri, WKWebView, and AppKit. Each single-window web fixture was reported as having five same-PID layer-0 siblings because raw WindowServer compositor surfaces were counted as windows.The separate Electron foreground pixel-drag failure remains tracked in #2906 and is not changed here.
Tests
cargo fmt --manifest-path libs/cua-driver/rust/Cargo.toml --all -- --checkcargo test --manifest-path libs/cua-driver/rust/Cargo.toml -p platform-macos --lib(331 passed)Follow-up certification
Before merge, rerun the affected background keyboard/editor cells and the real two-window ambiguity regression in a clean macOS VM. After merge, rerun the full canonical macOS matrix before publishing a release.