Skip to content

Conversation

@ibalosh
Copy link
Contributor

@ibalosh ibalosh commented Jan 21, 2026

ref https://linear.app/ghost/issue/ENG-454

what

Added trimming to all three entry points when saving user details: signup, profile update, and custom theme forms.

why

Member names with leading/trailing whitespace were being saved as-is, causing single-letter avatars and data quality issues.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

Walkthrough

Trims whitespace from name inputs in portal signup and profile update flows. apps/portal/src/actions.js now trims the signup name before constructing payloads (including when plan is 'free') and trims incoming member data before comparing/updating. apps/portal/src/data-attributes.js extracts the name input, trims it, and returns undefined for empty results. Tests in apps/portal/test/* were added/updated to assert trimmed names are sent to sendMagicLink and API update calls. apps/portal/package.json version bumped from 2.56.3 to 2.56.4.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing member name trimming in Portal. It accurately reflects the core purpose of the changeset.
Description check ✅ Passed The description directly relates to the changeset, explaining what was changed (trimming added to three entry points) and why it matters (preventing whitespace-related issues).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ibalosh ibalosh force-pushed the improve-portal-name-saves branch from 3ba756c to f862d44 Compare January 21, 2026 08:51
ref https://linear.app/ghost/issue/ENG-454

Member names with leading/trailing whitespace (often from mobile autofill)
were being saved as-is, causing single-letter avatars and data quality issues.
Added trimming to all three entry points: signup, profile update, and custom
theme forms.
@ibalosh ibalosh force-pushed the improve-portal-name-saves branch from f862d44 to 8301c3b Compare January 21, 2026 09:06
@ibalosh ibalosh requested a review from sagzy January 21, 2026 10:48
Changelog for v2.56.3 -> 2.56.4:
  - 8301c3bcb2
@ibalosh ibalosh enabled auto-merge (squash) January 21, 2026 11:06
@ibalosh ibalosh merged commit eb83f22 into main Jan 21, 2026
35 checks passed
@ibalosh ibalosh deleted the improve-portal-name-saves branch January 21, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants