-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Release new admin shell and sidebar #25955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request removes the Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
91c9ea8 to
8fd4601
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25955 +/- ##
==========================================
- Coverage 72.55% 72.51% -0.05%
==========================================
Files 1546 1548 +2
Lines 118601 119027 +426
Branches 14306 14359 +53
==========================================
+ Hits 86053 86312 +259
- Misses 31508 31692 +184
+ Partials 1040 1023 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Does this mean we can remove the duplicate e2e tests for Ember in CI now? No opinion on whether that should be included here or in a follow up, just curious and excited to simplify that 😄 |
|
Yeah, thats correct! I have a separate tasks for that since there are some additional cleanup that goes along with it. |
8fd4601 to
2dc087c
Compare
closes https://linear.app/ghost/issue/BER-3230/release-new-admin-shell
Removed the feature flagging and conditionals so that we always serve the new admin shell. This includes the new sidebar UI and a significantly improved local developer experience via
yarn dev:forward(soon to be renamedyarn dev.)