🎨 Improved author selection performance on sites with many staff users#29044
Merged
Conversation
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost-admin:test |
✅ Succeeded | 3m 5s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 1m 59s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | <1s | View ↗ |
nx run-many -t lint -p ghost-admin |
✅ Succeeded | 13s | View ↗ |
nx run ghost:build:assets |
✅ Succeeded | 1s | View ↗ |
nx run ghost:build:tsc |
✅ Succeeded | 8s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | <1s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-13 17:22:38 UTC
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
👮 Files not reviewed due to content moderation or server errors (1)
Warning Walkthrough skippedFile diffs could not be summarized. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ref https://linear.app/ghost/issue/BER-3760/admin-is-inefficient-on-sites-with-large-numbers-of-staff - on sites with very large staff lists, Admin fetched every user up-front to populate author dropdowns — with 18k+ staff that meant 180+ API requests before the post settings menu or the posts screen were usable - extracted the tags input's paginate-on-scroll + server-side search behaviour into an abstract `GhPaginatedOptions` component: options load a page at a time when the dropdown opens, search queries the API until every option has been loaded, then switches to client-side filtering - added two components on that base: a multi-select `GhPaginatedTokenInput` and a single-select `GhPaginatedFilterSelect` - rebuilt the post settings menu authors input and the tags input on `GhPaginatedTokenInput`, so authors load a page at a time and searching queries the API across name, slug, and email - rebuilt the posts/pages screens' author and tag filters on `GhPaginatedFilterSelect`, replacing the eager all-users fetch and the bespoke tag pagination logic that lived in the posts controller; deep-linked `?author=` filters now resolve with a single by-slug lookup - consolidated the NQL search-term escaping that was duplicated across tags, labels, and resource-select searches into a shared `escapeNqlString` util
kevinansfield
force-pushed
the
ber-3760-paginated-authors-input
branch
from
July 13, 2026 17:17
43895a3 to
d815234
Compare
kevinansfield
enabled auto-merge (squash)
July 13, 2026 17:18
vershwal
pushed a commit
that referenced
this pull request
Jul 13, 2026
#29044) closes https://linear.app/ghost/issue/BER-3760/ On sites with very large staff lists, Admin fetched every user up-front to populate author dropdowns — with 18k+ staff that meant 180+ API requests before the post settings menu or the posts screen were usable. - extracted the tags input's paginate-on-scroll + server-side search behaviour into an abstract `GhPaginatedOptions` component: options load a page at a time when the dropdown opens, search queries the API until every option has been loaded, then switches to client-side filtering - added two components on that base: a multi-select `GhPaginatedTokenInput` and a single-select `GhPaginatedFilterSelect` - rebuilt the post settings menu authors input and the tags input on `GhPaginatedTokenInput`, so authors load a page at a time and searching queries the API across name, slug, and email - rebuilt the posts/pages screens' author and tag filters on `GhPaginatedFilterSelect`, replacing the eager all-users fetch and the bespoke tag pagination logic that lived in the posts controller; deep-linked `?author=` filters now resolve with a single by-slug lookup - consolidated the NQL search-term escaping that was duplicated across tags, labels, and resource-select searches into a shared `escapeNqlString` util
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/ghost/issue/BER-3760/admin-is-inefficient-on-sites-with-large-numbers-of-staff
On sites with very large staff lists, Admin fetched every user up-front to populate author dropdowns — with 18k+ staff that meant 180+ API requests before the post settings menu or the posts screen were usable.
GhPaginatedOptionscomponent: options load a page at a time when the dropdown opens, search queries the API until every option has been loaded, then switches to client-side filteringGhPaginatedTokenInputand a single-selectGhPaginatedFilterSelectGhPaginatedTokenInput, so authors load a page at a time and searching queries the API across name, slug, and emailGhPaginatedFilterSelect, replacing the eager all-users fetch and the bespoke tag pagination logic that lived in the posts controller; deep-linked?author=filters now resolve with a single by-slug lookupescapeNqlStringutil