Fall back to display name when a published-post email has no username - #325
Merged
Merged
Conversation
Facebook Pages often have no vanity username, which left the email as "Facebook Page (@)". Use username, then display name, and omit the empty parentheses when both are missing.
The fallback belongs on the row that always has a platform, so mail and in-app notify can call one method instead of guarding a missing social account at every call site.
The email tests were not enough — SendNotification body is what the in-app inbox shows, and that path also goes through notificationLabel().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
username(InboxPlacement.io isnullin prod), so the published-post email renderedFacebook Page (@).SocialAccount::labeledHandle()now uses username, then display name, and drops the empty(@)when both are missing — same rule for the failed-post email and the in-app notification.Test plan
username = nulland a display name — email should showFacebook Page (@InboxPlacement.io), notFacebook Page (@)Bluesky (@handle)