fix: Revert AGENT_SANDBOX env var renames to AGENT_EXECUTOR - #355
Conversation
|
| Filename | Overview |
|---|---|
| charts/retool/templates/deployment_js_executor.yaml | Adds AppArmor selection and readiness waiting, but its gate can render the waiter without the required installer DaemonSet. |
| charts/retool/templates/apparmor_nsjail_daemonset.yaml | Adds the privileged per-node profile installer, whose workflows-only render gate is incompatible with independently enabled js-executor. |
| charts/retool/templates/deployment_agent_sandbox.yaml | Adds an AppArmor readiness gate and profile selection to sandbox jobs plus writable temporary volumes for controller and proxy. |
| charts/retool/templates/agent_sandbox_seccomp.yaml | Extends the existing sandbox node installer to load the optional AppArmor profile and publish a per-node readiness marker. |
| .github/test-apparmor.sh | Adds end-to-end profile verification, with a non-blocking supply-chain concern from executing the mutable k3s installer as root. |
| .github/workflows/ci.yaml | Adds the AppArmor integration job as a required validation dependency. |
| charts/retool/values.yaml | Adds disabled-by-default AppArmor installer options for executor and agent-sandbox workloads. |
Reviews (1): Last reviewed commit: "Revert AGENT_SANDBOX_* -> AGENT_EXECUTOR..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| {{- if .Values.codeExecutor.appArmorProfileInstaller }} | ||
| - name: wait-for-apparmor | ||
| image: busybox:1.37.0@sha256:b3255e7dfbcd10cb367af0d409747d511aeb66dfac98cf30e97e87e4207dd76f | ||
| securityContext: | ||
| allowPrivilegeEscalation: false | ||
| readOnlyRootFilesystem: true | ||
| capabilities: | ||
| drop: ["ALL"] | ||
| resources: | ||
| requests: | ||
| cpu: 1m | ||
| memory: 4Mi | ||
| limits: | ||
| cpu: 10m | ||
| memory: 16Mi | ||
| command: | ||
| - /bin/sh | ||
| - -c | ||
| - | | ||
| until [ -f /host-run/retool-executor.loaded ]; do | ||
| echo "Waiting for AppArmor profile retool-executor to be loaded by DaemonSet..." | ||
| sleep 2 | ||
| done | ||
| echo "AppArmor profile retool-executor loaded" | ||
| volumeMounts: | ||
| - name: host-run | ||
| mountPath: /host-run | ||
| readOnly: true |
There was a problem hiding this comment.
When rr.jsExecutor.enabled=true, codeExecutor.appArmorProfileInstaller=true, and workflows remain disabled, this init container waits for retool-executor.loaded even though the workflows-gated DaemonSet that creates it is not rendered, leaving every js-executor pod stuck in initialization.
| echo " k3s is already running, skipping install." | ||
| else | ||
| echo " Installing k3s..." | ||
| curl -sfL https://get.k3s.io | INSTALL_K3S_EXEC="--disable=traefik" sh - |
There was a problem hiding this comment.
The new CI job reaches this unversioned curl | sh path on each fresh runner and executes the downloaded response as root, making CI behavior dependent on mutable remote content and granting a compromised response full control of the runner.
How this was verified: The workflow invokes this script with sudo, and the fresh-runner branch pipes https://get.k3s.io directly into sh without integrity verification.
The env var names should stay as AGENT_SANDBOX_* to match what the application expects. The rename to AGENT_EXECUTOR_* was incorrect. Co-authored-by: Cursor <cursoragent@cursor.com>
12daccf to
f9caad0
Compare
Merge activity
|
3 participants
Summary
Reverts the incorrect
AGENT_SANDBOX_*→AGENT_EXECUTOR_*env var renames that were included in #353. The application expectsAGENT_SANDBOX_*names.Changes:
AGENT_EXECUTOR_POSTGRES_URL→AGENT_SANDBOX_POSTGRES_URLAGENT_EXECUTOR_ROLE→AGENT_SANDBOX_ROLEAGENT_EXECUTOR_POSTGRES_SCHEMA→AGENT_SANDBOX_POSTGRES_SCHEMAAGENT_EXECUTOR_POSTGRES_POOL_MAX→AGENT_SANDBOX_POSTGRES_POOL_MAXAGENT_EXECUTOR_JWT_PUBLIC_KEY→AGENT_SANDBOX_JWT_PUBLIC_KEYAGENT_EXECUTOR_ENCRYPTION_KEY→AGENT_SANDBOX_ENCRYPTION_KEYMade with Cursor