Skip to content

chore: drop the lint dependency group - #502

Merged
tschm merged 2 commits into
mainfrom
chore/drop-lint-group
Aug 4, 2026
Merged

chore: drop the lint dependency group#502
tschm merged 2 commits into
mainfrom
chore/drop-lint-group

Conversation

@tschm

@tschm tschm commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Removes the lint dependency group from pyproject.toml and relocks uv.lock.

Nothing referenced the group by name — CI syncs with --all-groups, and the tools it carried remain available without it:

  • make typecheck runs mypy via uv run --with mypy, not from the group
  • ruff comes from the pre-commit hooks

Also drops test_lint_group_present from .rhiza/tests/test_pyproject.py, which asserted the group just removed.

Note on .rhiza/

.rhiza/tests/test_pyproject.py is template-owned, so the next /rhiza:update will restore test_lint_group_present unless the same change lands upstream in jebel-quant/rhiza. .rhiza/CONTRIBUTING.md also still documents uv sync --group lint; that line is template-owned too and left untouched here.

Verification

  • uv lock --check passes
  • pytest .rhiza/tests/test_pyproject.py → 23 passed
  • all pre-commit hooks pass, including uv-lock

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed the separate lint dependency group and its development tools.
    • Updated project validation to no longer require a dedicated lint group.
    • Test dependency group validation remains unchanged.

Remove the [dependency-groups] lint group and relock. The tools it
carried are still available without it: `make typecheck` runs mypy via
`uv run --with mypy`, and ruff comes from the pre-commit hooks.

Also drop test_lint_group_present from .rhiza/tests/test_pyproject.py,
which required the group just removed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 4, 2026 07:23
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@tschm, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f364a02-f88b-4ac3-8150-7a1c41403f2b

📥 Commits

Reviewing files that changed from the base of the PR and between 22e2071 and ab2b556.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml
📝 Walkthrough

Walkthrough

The lint dependency group, including mypy and ruff, was removed from pyproject.toml. The related documentation and test assertion were removed. Validation for the test dependency group remains.

Changes

Dependency group requirements

Layer / File(s) Summary
Remove lint group documentation and test
.rhiza/tests/test_pyproject.py
The documentation requirement and test assertion for the lint dependency group were removed. Validation for the test dependency group remains unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: removing the lint dependency group.
Description check ✅ Passed The description explains the change, rationale, affected test, template-owned files, and verification results, but it omits several template headings and checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/drop-lint-group

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the lint dependency group from the project’s dependency groups, updates the UV lockfile to reflect the change, and drops the corresponding template test that asserted the presence of the lint group.

Changes:

  • Removed [dependency-groups].lint from pyproject.toml.
  • Updated uv.lock to remove the lint dev-dependency group and associated packages.
  • Removed the .rhiza template test that required a lint dependency group.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
uv.lock Removes the lint dev-dependency group and updates the locked dependency graph.
pyproject.toml Drops the lint dependency group from [dependency-groups].
.rhiza/tests/test_pyproject.py Removes the template test enforcing the presence of a lint dependency group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tschm
tschm merged commit c7f793a into main Aug 4, 2026
66 checks passed
@tschm
tschm deleted the chore/drop-lint-group branch August 4, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants