parse and render parameter set directives (record 43) - #171
Merged
ShiboSoftwareDev merged 7 commits intoSep 10, 2026
Merged
Conversation
|
@anil08607 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
ShiboSoftwareDev
approved these changes
Sep 10, 2026
ShiboSoftwareDev
left a comment
Contributor
There was a problem hiding this comment.
just remove the committed artifacts
Collaborator
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AltiumSchParameterSetRecord(and aliasAltiumSchDifferentialPairRecord) for schematicRECORD=43.RECORD=43inrecordConstructorsto eliminate fallback toAltiumUnknownRecord.parameterSetsanddifferentialPairsconvenience getters toAltiumSchDoc.Background
In Altium schematic documents (
.SchDoc),RECORD=43represents a Parameter Set directive (such as Differential Pair directives likeDIFFPAIRor net class directives like1A). Previously, these records had no dedicated class and parsed asAltiumUnknownRecord, leaving directives unrendered in SVG outputs.Changes
lib/records/altium-schematic-records.ts:name,color, andisDifferentialPairaccessors toAltiumSchParameterSetRecord.AltiumSchDifferentialPairRecordalias.lib/parser/record-constructors.ts:"43": AltiumSchParameterSetRecord.lib/altium-sch-doc.ts:parameterSetsanddifferentialPairsgetters.lib/svg-serialization/serialize-altium-sheet-to-svg.ts:RECORD=43directive marker and label.tests/schematic-parameter-set.test.ts:tests/svg/schematic-parameter-set.test.ts:tests/svg/__snapshots__/schematic-component-value-reference.snap.svg(now includesDIFFPAIRdirectives fromstm32-st-link-v2.SchDoc).tests/svg/__snapshots__/schematic-note-text-frame-repro.snap.svg(now includes1Adirective marker frompidp11-io-expander.SchDoc).