Reproduce misplaced Game Boy Advance clearance markers - #276
Merged
Conversation
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supplied Game Boy Advance export has 11 clearance markers placed at full-trace or object midpoints instead of the offending copper gap. This PR reproduces every clearance error and its exact coordinates without changing check behavior. It also reproduces the twelfth, via-in-pad placement error, which has no location field in the current circuit-json schema.
Adds the PCB/connectivity fixture, exact position assertions, renderer and numbered-coordinate SVG snapshots, and a coordinate table in
docs/gameboy-clearance-locations.md. Stored errors are removed before rerunning the checks; all generated fields except core-reassigned IDs match the export.Validation: all 293 tests pass; TypeScript, build, formatting and all GitHub CI checks pass. The follow-up fix is #277, stacked on this PR.