Skip to content

Fix schematic section titles overlapping chip reference designators - #3814

Merged
seveibar merged 3 commits into
mainfrom
fix/schematic-section-title-reference-overlap
Sep 9, 2026
Merged

Fix schematic section titles overlapping chip reference designators#3814
seveibar merged 3 commits into
mainfrom
fix/schematic-section-title-reference-overlap

Conversation

@seveibar

@seveibar seveibar commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Schematic section titles can overlap the reference designator above the top-left chip because section bounds only include component bodies. Include component-owned reference/value text in those bounds and keep the bottom of each title above the section contents, accounting for sectionTitleFontSize.

Adds a visual regression covering a chip and a chip-backed schematic box on separate sheets, with default and enlarged titles. Refreshes affected section snapshots and the existing RC-car title-position expectations. Completes the plated-hole test's upstream change to check hole-pair errors consistently, without requiring dependency-specific courtyard errors.

Validation:

  • The regression fails against the original section renderer and passes with the fix.
  • bunx tsc --noEmit passes.
  • All seven tests that failed in the initial CI run pass locally after refreshing the remaining snapshots and correcting the plated-hole assertion.
  • Visually inspected the new two-sheet regression render.

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tscircuit-core-benchmarks Ready Ready Preview Sep 9, 2026 11:40pm UTC

Request Review

@seveibar
seveibar merged commit 3215342 into main Sep 9, 2026
17 checks passed
@seveibar
seveibar deleted the fix/schematic-section-title-reference-overlap branch September 9, 2026 23:56
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating:
Impact: Tiny

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants