Fix schematic section titles overlapping chip reference designators - #3814
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schematic section titles can overlap the reference designator above the top-left chip because section bounds only include component bodies. Include component-owned reference/value text in those bounds and keep the bottom of each title above the section contents, accounting for
sectionTitleFontSize.Adds a visual regression covering a chip and a chip-backed schematic box on separate sheets, with default and enlarged titles. Refreshes affected section snapshots and the existing RC-car title-position expectations. Completes the plated-hole test's upstream change to check hole-pair errors consistently, without requiring dependency-specific courtyard errors.
Validation:
bunx tsc --noEmitpasses.