Forward disabled flags from JSON config#3334
Draft
imrishabh18 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tscircuit.config.jsonwith optional TypeScript/JavaScript configTSCIRCUIT_CONFIG_PATHSdiscovery listpcbDisabledandschematicDisabledvalues into the effective platform configPartial<PlatformConfig>for the shared config fields instead of extending a separate config interface@tscircuit/propsto^0.0.588platformConfigWhy
tscircuit.config.jsonwas previously used only to infer the entrypoint. Because it was not included in the runtime config passed to platform setup, its disabled flags never reachedRootCircuit.Impact
Projects can now use
pcbDisabledorschematicDisabledintscircuit.config.jsonand have those settings applied consistently by bothCircuitRunnerand the web worker. JSON and module configuration continue to merge, with moduleplatformConfigvalues retaining precedence.Validation
bun test tests/features/platform-config.test.tsx tests/features/parts-engine-platformConfig.test.tsbun test tests/examples/example17-parse-tscircuit-config.test.tsxbun run format:checkbun run buildThe full test suite was previously attempted; an unrelated existing test (
should-hint-main-component-path-when-entrypoint-exports-component) timed out at five seconds, after which the run was stopped.