Fill rectdiff gaps across multiple passes using maxGapFillPasses - #133
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0hmX
changed the title
0hmX
marked this pull request as ready for review
June 23, 2026 16:46
0hmX
force-pushed
the
codex/recursive-gap-fill-passes
branch
from
June 24, 2026 10:52
e945ed2 to
bd2dd7c
Compare
0hmX
changed the title
Contributor
|
should be benchmark? |
seveibar
approved these changes
Jun 24, 2026
seveibar
left a comment
seveibar
left a comment
Contributor
There was a problem hiding this comment.
i see the benchmark now
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The previous gap fill only expanded once. Small corner-overlap gaps could require newly expanded nodes to participate in a later find/expand pass, leaving visible holes after the first pass.
Repro that got fixed
https://github.com/tscircuit/rectdiff/pull/133/changes#diff-5c564705806d916d0571b38e7be681977131bc6048582367372e594702516047