Add analog simulation analyses and parameter sweep RFC#9
Merged
Conversation
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
reviewed
Jul 20, 2026
seveibar
left a comment
Contributor
There was a problem hiding this comment.
keep the RFC small and focused on circuit json and TSX usage examples- the spec is far more important than anything else and the RFC doesn't focus sufficiently on it. Also the RFC should be smaller
Make sure you understand every line, remove lines like this (they waste the time of the reviewer)
The ngspice adapter must serialize access to one cached mutable simulation
instance. Parallelism is valid only through a bounded pool of independent
instances; a worker pool is not part of MVP.
seveibar
reviewed
Jul 21, 2026
seveibar
reviewed
Jul 21, 2026
seveibar
reviewed
Jul 21, 2026
seveibar
reviewed
Jul 21, 2026
seveibar
approved these changes
Jul 21, 2026
ShiboSoftwareDev
marked this pull request as ready for review
July 21, 2026 18:43
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<analog.*simulation>elements for transient, DC operating point, direct DC sweep, and AC sweep usage<analog.sweepparameter>with parameter-specific target props<analogsimulation>transient spelling and transient graph elementsScope
This RFC is intentionally limited to TSX usage and the corresponding Circuit JSON. Compiler, engine, scheduling, rendering, export, measurement-expression, and implementation-order contracts are outside its scope.
Validation
git diff --check