Skip to content

feat: enhance StructureService with 3D Beacons API integration - #66

Merged
tsenoner merged 3 commits into
mainfrom
feat/3d-beacons
Oct 19, 2025
Merged

feat: enhance StructureService with 3D Beacons API integration#66
tsenoner merged 3 commits into
mainfrom
feat/3d-beacons

Conversation

@peymanvahidi

@peymanvahidi peymanvahidi commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator

Description

Switch availability checks for AlphaFold structures to the 3D Beacons summary API.
Add two buttons to redirect to UniProt/AlphaFold DB

Fixes: #24

Type of change

  • New feature (non-breaking change which adds functionality)

Test Configuration:

  • macOS
  • Chrome (latest)

Checklist

  • I linted my code with ESLint and formatted it with Prettier
  • I used an AI tool for a self-review
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@peymanvahidi

Copy link
Copy Markdown
Collaborator Author

next, I'm going to add buttons, so that you can go to the selected proteins UniProt or AlphaFold DB

@peymanvahidi
peymanvahidi requested a review from tsenoner October 17, 2025 15:25
@tsenoner

Copy link
Copy Markdown
Owner

As discussed, pls change the buttons to links directly over the text.

@peymanvahidi

Copy link
Copy Markdown
Collaborator Author

@tsenoner Check it out

@tsenoner
tsenoner merged commit 9701873 into main Oct 19, 2025
2 checks passed
@tsenoner
tsenoner deleted the feat/3d-beacons branch October 19, 2025 19:37
tsenoner added a commit that referenced this pull request Aug 13, 2026
Three bookkeeping fixes found reviewing the archive:

- `#66`/`#55`/`#60` in the monorepo change's reconciled tasks are protspace-legacy
  PRs, but bare `#N` autolinks against this repo. `#66` is the silent case: it
  resolves to a merged, unrelated frontend PR ("enhance StructureService with 3D
  Beacons API integration") rather than 404ing, so the link looks fine and points
  somewhere wrong. The intended one is "bundle format v2 — lossless annotation name
  encoding", which is what the surrounding text describes. `#306`/`#295`/`#233`/`#445`
  are genuine refs here and stay bare.
- design.md still described `_INCOMPATIBLE` as (blocked set, why, remedy); 3cdacf9
  collapsed it to (blocked set, note). The archive commit landed before that refactor
  and nothing re-reconciled after.
- A 5.3 checkbox was ticked while its own text read "carried forward to #447 rather
  than ticked". Reworded so the box and the sentence agree.

openspec validate --all --strict: 20 passed, 0 failed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ar6ME3o6VYLYsie3J4kxE5
tsenoner added a commit that referenced this pull request Aug 13, 2026
…e impact list

Two AGENTS.md conformance fixes on the previous commit and the archive:

- 53b231f expanded every `#66`/`#55`/`#60` mention inline. AGENTS.md asks for the
  opposite: qualify once on a definitional line and keep the body bare, since full
  qualification turns headings into `### 2.3 tsenoner/protspace-legacy#57: ...`. The
  body goes back to bare `#N` and a `**Refs:**` line in the header blockquote carries
  the disambiguation.
- "Archive before the merge" asks that proposal.md and design.md be reread against the
  final diff, because archiving freezes them. The archive commit predates the cleanup
  in 3cdacf9, so its Impact list named neither test file nor CLAUDE.md and described
  a gating shape that no longer exists. Both recorded; the requirements are unchanged
  by the refactor.

openspec validate --all --strict: 20 passed, 0 failed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ar6ME3o6VYLYsie3J4kxE5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Switch structure search to 3d beacons

2 participants