refactor!: table row/iteration rewrite#857
Merged
Merged
Conversation
molpopgen
force-pushed
the
refactor_table_row_and_row_iter
branch
from
6524f43 to
06e7337
Compare
* Rely directly on C types now, unifying the two API
molpopgen
force-pushed
the
refactor_table_row_and_row_iter
branch
from
06e7337 to
2db00d3
Compare
This was referenced Apr 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites table row accessors and row iterators to make direct use of C types.
This breaks API but has several benefits, including fewer lines of code, more zero-copy semantics by default, and maybe a couple of other things I'm forgetting...