Take a copy when making arrays for asdict #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1029 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 26 26
Lines 20846 20848 +2
Branches 859 859
=======================================
+ Hits 19531 19533 +2
Misses 1277 1277
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
benjeffery
force-pushed
the
fix-asdict
branch
from
55cb126 to
71c5ba5
Compare
Collaborator
|
📖 Docs for this PR can be previewed here |
benjeffery
force-pushed
the
fix-asdict
branch
3 times, most recently
from
74f5be3 to
be2c27f
Compare
Member
Author
|
I've also modified the tests to use a fixture, this reduces the test time to 25% of what it was. This helps in the stress test which I have run to 2000 iterations without seeing any leaks. |
jeromekelleher
approved these changes
Nov 23, 2020
| lwt = lwt_module.LightweightTableCollection() | ||
| lwt_dict = lwt.asdict() | ||
| del lwt | ||
| print(lwt_dict) |
benjeffery
force-pushed
the
fix-asdict
branch
from
be2c27f to
8b464a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
tskit.LightweightTableCollectionandtskit.TableCollectionwere not taking copies of arrays, leading to lifecycle errors where the array could be deallocated.Fixes #1025
PR Checklist: