Skip to content

Conversation

@benjeffery
Copy link
Member

Fixes #1171

@benjeffery benjeffery force-pushed the deprecate-py3.6 branch 2 times, most recently from 0103cd5 to adbc691 Compare March 9, 2021 13:54
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjeffery benjeffery force-pushed the deprecate-py3.6 branch 5 times, most recently from 4e46c91 to b0d0b92 Compare March 9, 2021 14:24
@benjeffery
Copy link
Member Author

Hmm, getting an error that suggests that msprime and the LWT have been built on different versions of numpy. I've nuked the cache.

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #1235 (063114c) into main (eedbb84) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   93.71%   93.71%           
=======================================
  Files          26       26           
  Lines       21618    21618           
  Branches      909      909           
=======================================
  Hits        20260    20260           
  Misses       1319     1319           
  Partials       39       39           
Flag Coverage Δ
c-tests 92.50% <ø> (ø)
lwt-tests 92.97% <ø> (ø)
python-c-tests 94.91% <ø> (ø)
python-tests 98.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedbb84...063114c. Read the comment docs.

@benjeffery benjeffery marked this pull request as ready for review March 10, 2021 11:25
@benjeffery benjeffery mentioned this pull request Mar 10, 2021
3 tasks
@hyanwong
Copy link
Member

Hmm, any reason this hasn't merged yet @benjeffery ?

@benjeffery
Copy link
Member Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2021

Command refresh: success

Pull request refreshed

@benjeffery benjeffery merged commit 1a7f6d0 into tskit-dev:main Mar 10, 2021
@benjeffery benjeffery deleted the deprecate-py3.6 branch March 10, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop python 3.6

3 participants