var used without initialize

[bhaller]

Hi all. On my present build platform, I'm getting a "used without initialize" warning on tables.c:256:

        if (offset_array[*num_rows] != (tsk_size_t) data_len) {

for data_len. I think the compiler might actually have a point. It starts out uninitialized, and only gets set up in the if (ret == 1) branch at line 191. If ret is != 1 then the branch at line 203 might happen, and goto out, but it looks like it might not, too, in which case it looks like one might reach line 256 without data_len ever being initialized...? Anyhow, I've only looked at the code superficially, so maybe there's no problem, but in any case a fix that avoids the warning would be nice. :-> Thanks!

[petrelharp]

Hm - I think it's fine because that block will only be visited if offset_col_present, which is ret == 1. (But we could certainly initialize it anyhow.)