Skip to content

Conversation

@jeromekelleher
Copy link
Member

@jeromekelleher jeromekelleher commented Nov 14, 2021

Closes #1686

Doesn't look too bad noise-wise, and seems worth the update?

I wondered if there was something fancy we could do with unions that would allow us to use either tree.interval.left or tree.interval[0]``, depending on the need, but I don't think it's possible in C99 (and would be of very marginal benefit anyway)

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #1913 (5858323) into main (6a803c6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1913      +/-   ##
==========================================
- Coverage   93.16%   93.16%   -0.01%     
==========================================
  Files          27       27              
  Lines       25094    25093       -1     
  Branches     1109     1109              
==========================================
- Hits        23379    23378       -1     
  Misses       1681     1681              
  Partials       34       34              
Flag Coverage Δ
c-tests 92.21% <100.00%> (-0.01%) ⬇️
lwt-tests 89.14% <ø> (ø)
python-c-tests 68.29% <100.00%> (ø)
python-tests 98.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/haplotype_matching.c 95.07% <100.00%> (ø)
c/tskit/trees.c 94.18% <100.00%> (-0.01%) ⬇️
python/_tskitmodule.c 90.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a803c6...5858323. Read the comment docs.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit c423031 into tskit-dev:main Nov 15, 2021
@jeromekelleher jeromekelleher deleted the tree-interval-refactor branch November 15, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change tsk_tree_t.left/right to an interval.

2 participants