Skip to content

Conversation

@nspope
Copy link
Contributor

@nspope nspope commented May 28, 2025

Fixes #3175 via a faulty interval intersection in the C implementation, and adds a test that would fail on main

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (4195624) to head (48b52c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3176   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files          28       28           
  Lines       31969    31969           
  Branches     5873     5873           
=======================================
  Hits        28653    28653           
  Misses       1886     1886           
  Partials     1430     1430           
Flag Coverage Δ
c-tests 86.66% <100.00%> (ø)
lwt-tests 80.38% <ø> (ø)
python-c-tests 88.18% <ø> (ø)
python-tests 98.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
c/tskit/trees.c 90.61% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nspope nspope force-pushed the coalcounts-normalise-fix branch from 8242f49 to 48b52c2 Compare May 28, 2025 03:13
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM

@jeromekelleher jeromekelleher added this pull request to the merge queue May 28, 2025
Merged via the queue into tskit-dev:main with commit c86884d May 28, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect span normalisation for ts.pair_coalescence_counts with missing data and windows

2 participants