Skip to content

Conversation

@daniel-goldstein
Copy link
Member

@daniel-goldstein daniel-goldstein commented Apr 2, 2020

The KC distance is only defined on full trees and unary nodes greatly affect distances. kc_distance now errors on trees with unary nodes. Users should run simplify on trees before comparing.

Resolves #487

cc @jeromekelleher @hyanwong

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #508 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   86.81%   86.82%           
=======================================
  Files          21       21           
  Lines       15969    15979   +10     
  Branches     3102     3105    +3     
=======================================
+ Hits        13864    13874   +10     
  Misses       1055     1055           
  Partials     1050     1050           
Flag Coverage Δ
#c_tests 87.74% <100.00%> (+0.01%) ⬆️
#python_c_tests 90.52% <ø> (ø)
#python_tests 99.18% <ø> (ø)
Impacted Files Coverage Δ
c/tskit/core.c 90.47% <100.00%> (+0.06%) ⬆️
c/tskit/trees.c 90.74% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43300e8...866b395. Read the comment docs.

@jeromekelleher
Copy link
Member

LGTM, thanks @daniel-goldstein!

@jeromekelleher jeromekelleher merged commit 9236a9e into tskit-dev:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kc_distance doesn't ignore unary nodes

2 participants