Skip to content

Conversation

@petrelharp
Copy link
Contributor

@petrelharp petrelharp commented Aug 7, 2020

Thanks to @molpopgen, this seems to fix problems that prevent including the C files in C++ (see MesserLab/SLiM#101 (comment)). I have no idea if there's a better way to do this.

@jeromekelleher
Copy link
Member

LGTM - great to get this sorted out before we tag C 0.99.4 too.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #755 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #755   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files          24       24           
  Lines       19387    19387           
  Branches     3640     3640           
=======================================
  Hits        17001    17001           
  Misses       1297     1297           
  Partials     1089     1089           
Flag Coverage Δ
#c_tests 85.27% <ø> (ø)
#python_c_tests 90.16% <ø> (ø)
#python_tests 99.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/core.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80712e7...21909f5. Read the comment docs.

@petrelharp
Copy link
Contributor Author

Passing tests - shall we merge?

@mergify mergify bot merged commit 659a06a into tskit-dev:master Aug 7, 2020
@jeromekelleher
Copy link
Member

Yep - was just making sure that Windows was happy with this before giving the thumbs up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants