Skip to content

Remove const on tsk_treeseq_init #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Remove const on tsk_treeseq_init #1719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions c/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

**Breaking changes**

- The ``tables`` argument to ``tsk_treeseq_init`` is no longer ``const``, to allow for future no-copy tree sequence creation.
(:user:`benjeffery`, :issue:`1718`, :pr:`1719`)

**Features**

- The default behaviour for table size growth is now to double the current size of the table.
Expand Down
2 changes: 1 addition & 1 deletion c/tskit/trees.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ tsk_treeseq_init_nodes(tsk_treeseq_t *self)
*/
int TSK_WARN_UNUSED
tsk_treeseq_init(
tsk_treeseq_t *self, const tsk_table_collection_t *tables, tsk_flags_t options)
tsk_treeseq_t *self, tsk_table_collection_t *tables, tsk_flags_t options)
{
int ret = 0;
tsk_id_t num_trees;
Expand Down
2 changes: 1 addition & 1 deletion c/tskit/trees.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ typedef struct {
@{
*/
int tsk_treeseq_init(
tsk_treeseq_t *self, const tsk_table_collection_t *tables, tsk_flags_t options);
tsk_treeseq_t *self, tsk_table_collection_t *tables, tsk_flags_t options);

int tsk_treeseq_load(tsk_treeseq_t *self, const char *filename, tsk_flags_t options);
int tsk_treeseq_loadf(tsk_treeseq_t *self, FILE *file, tsk_flags_t options);
Expand Down