Fix Microsoft Store installer parameters - #196
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 21 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ceiling | 7d7c2b3 | Commit Preview URL Branch Preview URL |
Aug 01 2026, 06:14 AM |
There was a problem hiding this comment.
Pull request overview
This PR addresses a Microsoft Store (Partner Center) submission rejection by ensuring the generated Store package JSON uses installer parameters that fit Partner Center’s 40-character limit, while moving startup-prompt suppression and “restart required” (3010) signaling into the Inno Setup installer itself. It also adds a deterministic regression test to keep this behavior from regressing locally and in CI.
Changes:
- Add a validated
InstallerParametersinput (max 40 chars) to Store submission preparation and assert it round-trips into the prepared JSON. - Update the Inno Setup script to suppress startup prompts and return exit code
3010when a restart is required. - Add a CI/local-check regression test for Store submission preparation and installer script invariants.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/prepare-store-submission.ps1 | Adds InstallerParameters handling (<=40 chars) and validates prepared output contains expected parameters. |
| scripts/local-check.ps1 | Runs Store submission preparation regression test as part of -ReleaseDoctor. |
| scripts/ci/test-store-submission-preparation.ps1 | New deterministic regression test covering JSON normalization + installer script invariants. |
| rust/installer/codexbar.iss | Moves startup-prompt suppression and restart-required exit code behavior into the installer. |
| .github/workflows/ci.yml | Runs the new Store submission preparation regression test in CI (Windows job). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0561b44 to
7d7c2b3
Compare
## Summary Prepares **Ceiling 1.5.22**, carrying three changes merged since v1.5.21: - **#198** - Fix 1% usage reading as 100% across providers (OpenCode Go, OpenCode, Qoder, Chutes, Sakana) - **#197** - OpenCode Go monthly bar labeled "Monthly" instead of "Extra" - **#196** - Fix Microsoft Store installer parameters (40-char Partner Center limit) Bumps all version sources to 1.5.22 (build 124), moves the Unreleased CHANGELOG section into a versioned 1.5.22 entry (adding the missing #196/#197 notes), and adds `.github/release-notes-1.5.22.md`. ## Changes - `CHANGELOG.md` - retitle Unreleased to `[Ceiling] 1.5.22 - 2026-08-03`, add #196/#197 entries - `version.env` - `MARKETING_VERSION=1.5.22`, `BUILD_NUMBER=124` - `rust/Cargo.toml`, `apps/desktop-tauri/src-tauri/Cargo.toml`, `apps/desktop-tauri/package.json`, `apps/desktop-tauri/src-tauri/tauri.conf.json`, `Cargo.lock` - version 1.5.22 - `.github/release-notes-1.5.22.md` - new release notes ## Validation `powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1 -All -Version 1.5.22` passes, including the release doctor for 1.5.22 (all version sources consistent, CHANGELOG mentions 1.5.22) and the Store submission preparation test. Expected pre-tag warnings only: local tag v1.5.22, local release assets, and GitHub release not found yet. After this merges and checks are green, push annotated tag `v1.5.22` to trigger the `Signed Windows Release` workflow. Co-authored-by: tsouth89 <tsouth89@users.noreply.github.com>
Summary
Why
The v1.5.21 Store submission was rejected because the inherited 67-character
InstallerParametersvalue exceeded Partner Center's maximum length of 40.Validation
powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\ci\test-store-submission-preparation.ps1powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1 -ReleaseDoctor -Version 1.5.21rust/installer/codexbar.isswith Inno Setup 6