fix(backlog): address architecture-review follow-ups from post-merge audit - #142
Merged
Merged
Conversation
…audit Fixes 7 findings from a dedicated architecture review of the GitHub backlog sync feature and execution-phase prompt driver (docs/plans backlog audit gap #10): cross-referenced Prompt/InitialPrompt doc comments, spawn now writes slash-commands/context file before starting the claude process instead of racing it, WriteBacklogContextFile carries prior-session history and plan artifacts consistently with the live CLI prompt, feature-flag toggles roll back disk state on controller failure instead of silently diverging, GitHub PR CI-label fetch runs concurrently instead of serially, the source-creation form is driven by a per-plugin field schema instead of hardcoded owner/repo, and GetSyncHistory reports a truncated flag when history is capped at 200. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Addresses post-merge architecture-review findings for the backlog sync feature and execution-phase prompt driver, focusing on correctness, race elimination, and better UI/API signaling.
Changes:
- Adds a truncation signal for sync history (proto + server + UI) and updates the web hook/service types accordingly.
- Eliminates a spawn-time race by ensuring directory sessions are prepared (dir exists + prewritten context/commands) before launching the session process.
- Improves reliability/perf with feature-flag rollback on controller failure and bounded-concurrency CI-label fetching for GitHub PR sync.
Reviewed changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| web-app/src/lib/hooks/useBacklogSourcesService.ts | Extends getSyncHistory to return { events, truncated } instead of just events. |
| web-app/src/gen/session/v1/session_pb.ts | Updates generated comments to clarify prompt vs initial_prompt semantics. |
| web-app/src/gen/session/v1/backlog_pb.ts | Adds generated truncated field to GetSyncHistoryResponse. |
| web-app/src/components/settings/BacklogSourcesSettings.tsx | Converts “Add Source” form to schema-driven fields and displays history truncation notice. |
| web-app/src/components/settings/BacklogSourcesSettings.test.tsx | Adds tests for schema field reset on plugin switch + truncation notice UI. |
| session/storage.go | Updates ListSourceSyncEvents signature to return truncation + adds CreateSourceSyncEvent delegation. |
| session/instance_worktree.go | Adds EnsureDirectorySessionPath helper and uses it for directory sessions. |
| session/instance.go | Clarifies docs for Prompt vs InitialPrompt and their delivery mechanisms. |
| session/ent_repository_backlog.go | Detects truncation by over-fetching sync events and returning (events, truncated). |
| session/backlog_sync_test.go | Updates tests for new return values and adds truncation edge-case coverage. |
| session/backlog_plugin_github_test.go | Adds regression test for concurrent CI-label fetching preserving per-PR labeling/order. |
| session/backlog_plugin_github_prs.go | Fetches CI labels concurrently with bounded errgroup to avoid timeouts. |
| session/backlog_context.go | Moves plan-artifacts line into BuildSessionInitialPrompt for consistent rendering. |
| session/backlog_commands_test.go | Updates call site for new WriteBacklogContextFile signature. |
| session/backlog_commands.go | Threads priorSessions through context file generation for consistency with live prompt. |
| server/services/feature_flags_test.go | Adds regression test for disk rollback when controller enable fails. |
| server/services/feature_flag_service.go | Rolls back persisted disk flag and returns an error if controller toggle fails. |
| server/services/backlog_service_test.go | Verifies GetSyncHistory surfaces truncation via proto. |
| server/services/backlog_service.go | Writes slash commands + context file before spawning session; returns truncated in RPC. |
| server/dependencies.go | Logs startup enable failures as errors (avoids “enabled” log on failure). |
| proto/session/v1/session.proto | Updates field comments for prompt vs initial_prompt. |
| proto/session/v1/backlog.proto | Adds GetSyncHistoryResponse.truncated. |
| project_plans/backlog-cross-platform-audit/gaps-and-risks.md | Marks architecture-review gap #10 as fixed with detailed changelog. |
Files not reviewed (2)
- gen/proto/go/session/v1/backlog.pb.go: Generated file
- gen/proto/go/session/v1/session.pb.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
✅ Registry ValidationTest Coverage: 4/158 features have
|
Contributor
E2E RPC Latency |
Contributor
📊 Feature E2E CoverageFeature coverage report unavailable
|
Contributor
Go Benchmarks (Tier 1) |
Contributor
Frontend Terminal Throughput |
Contributor
UX Analysis
|
Contributor
🎬 E2E Feature Demos2 shard(s) recorded feature flows for this PR. recordings shard 1 Demo preview opens directly in browser (single-file HTML). Raw WebM recordings in ZIP. Expires after 30 days. |
Fixes a CRITICAL path-resolution bug the reordering fix introduced (a tilde-prefixed repo_path would write pre-spawn files to the wrong location since the raw string bypassed NewInstance's tilde/abs resolution — extracted a shared session.ResolveSessionPath helper used by both), a CRITICAL gap where AttachSessionToItem's entItem omitted PlanArtifactsPath/PlanApproved/ SkipPlanning so its plan-artifacts reminder could never render, and a MAJOR race in UpdateFeatureFlag's rollback logic (added a per-service mutex so concurrent toggles of the same flag can't stomp each other's disk state). Also: reordered AttachSessionToItem to load prior sessions before creating its own ItemSession (matches SpawnSessionFromItem, no longer correct only by filter coincidence); wrapped rollback-failure errors so callers see when disk state may be inconsistent; extracted PLUGIN_SCHEMAS into its own module so a test can prove the source-creation form is genuinely schema-driven instead of coincidentally-identical; added a concurrency-boundedness assertion to the GitHub PRs CI-label fetch test; added regression coverage for the write-before-spawn ordering fix, EnsureDirectorySessionPath, and WriteBacklogContextFile's plan-artifacts/prior-sessions threading — all gaps a 5-agent parallel review + adversarial skeptic pass identified as untested. Filed one pre-existing, non-blocking DB index gap as a follow-up note rather than fixing out-of-scope schema in this PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- EnsureDirectorySessionPath: distinguish IsNotExist (create+git-init) from other stat errors (now returned, not silently swallowed as a no-op) - BacklogSourcesSettings: never send a leftover token for a plugin that doesn't require one; clear the token field on plugin switch - useBacklogSourcesService: coerce truncated to Boolean() so a falsy/ undefined wire value can't defeat the SyncHistoryResult contract Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
✅ Registry ValidationTest Coverage: 4/158 features have
|
- server/services/backlog_service_test.go: use session.Active instead of
the deprecated session.Running alias (staticcheck SA1019)
- session/backlog_plugin_github_test.go: use a tagged switch on
r.URL.Path instead of switch{case r.URL.Path == ...} (staticcheck QF1002)
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
✅ Registry ValidationTest Coverage: 4/158 features have
|
The test's fake Instance used Status: session.Active, which FromInstanceData/LoadInstances treats as a live session requiring cold process-manager restore (real tmux + claude process). That restore succeeds (slowly) in a local dev environment but times out in CI (no claude binary, sandboxed tmux), causing the instance to be silently skipped and the expected file never written. Status: session.Paused matches the same pattern already used elsewhere in this test suite and needs no live process, since AttachSessionToItem only matches on UUID+Path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
✅ Registry ValidationTest Coverage: 4/158 features have
|
TylerStaplerAtFanatics
added a commit
that referenced
this pull request
Jul 10, 2026
* refactor(session-types): unify SessionType, promote one_off to proto enum, split config
Eliminates three sources of type duplication:
1. config/types.go + config/executor.go extracted from the 1031-line config/config.go
(SRP fix — config.go now contains only factory functions and the Config struct)
2. session.SessionType is now a Go type alias for config.SessionType, removing the
duplicate type that required aliasSessionTypeToSessionType no-op conversions
3. bool one_off = 14 promoted to SESSION_TYPE_ONE_OFF = 5 in the SessionType proto enum;
field 14 is reserved for wire compatibility. All call sites updated: backend handler,
workflow scheduler, alias defaults service, and all frontend contexts/hooks/tests.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(headless): use Setsid instead of Noctty for headless runner subprocess
WithNoControllingTerminal() sets SysProcAttr.Noctty=true on Linux, which
calls ioctl(0, TIOCNOTTY) in the child after fork. This returns ENOTTY when
the parent process has no controlling terminal — the case when stapler-squad
runs as a systemd service — causing every headless triage call to fail with
"fork/exec .../claude: inappropriate ioctl for device" (exit code 1).
Replace WithNoControllingTerminal() with WithNewSession() in ProcessRunner.Run.
Setsid creates a new process session (implying no controlling terminal) without
invoking TIOCNOTTY, so it works regardless of whether the parent has a TTY.
Also corrects the misleading comment in managed_process_linux.go that claimed
Noctty was safe without a controlling terminal.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(omnibar): replace Create shortcut hint with clickable Create Session button
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(alias): add name_prefix field + fix session name oscillation
- Add `name_prefix` to AliasConfig (Go), AliasProto (proto field 12),
and AliasEntry (TypeScript) — wired through the full stack
- In the detection effect, skip the generic suggestedName update for
aliases; the alias block now derives the session name as
namePrefix + typedLabel, falling back to namePrefix alone or the
alias name — eliminates the oscillation between alias name and
prefix+label on each keystroke
- AliasesManager settings form now has a Name prefix field with a live
preview hint
- Create Session button in shortcuts bar uses compact styling on desktop
and expands to touch-friendly size on coarse-pointer (mobile) devices
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(detection): detect dynamic workflows + expand turn-marker to ✦
- Add "dynamic workflow" alternate to waiting_for_background_agent pattern
so "✻ Waiting for N dynamic workflow(s) to finish" → StatusWaitingForAgent
- Expand [✻◉] → [✻◉✦] in verb_duration_completion and
waiting_for_background_agent to cover ✦ (U+2726, Claude Code primary spinner)
- Add test cases for all three bullet variants on both waiting and completion lines
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(review-queue): show INPUT_REQUIRED items + UX improvements
- Fix invisible INPUT_REQUIRED/APPROVAL_PENDING items: deriveWorkingState
maps these to PROCESSING, which was being filtered out; now always
passes items through when their reason requires user action
- Fix workingCount to exclude INPUT_REQUIRED/APPROVAL_PENDING from the
"working" tally (they need attention, not patience)
- Fix summaryCount grammar ("input neededs", "task completes", "timed outs")
by replacing tuple pluralization with per-reason formatter functions
- Fix filter empty state: show "no items match" when a filter is active,
not the generic "all done" message
- Move auto-advance checkbox into the panel title row (was orphaned above
the card in page.tsx toolbar div)
- Hide floating help button on mobile (keyboard shortcuts are irrelevant
on touch devices)
- Increase filter button / toggle touch targets to 44px on mobile
- Downgrade oldest-item callout from alarming orange to neutral muted style
- Show filter toggle whenever any items exist (not only when server
totalItems > 0)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(alias): default session type + name oscillation
- Fix session type not applying for aliases configured as
"Default (directory)": that option stores SessionType.UNSPECIFIED,
which the detection effect was explicitly skipping — form stayed at
the initial "new_worktree" value instead. Now maps UNSPECIFIED → "directory".
- Fix session name oscillating every other keystroke: the generic
suggestedName block was running for InputType.Alias results and
resetting lastSuggestedNameRef to the alias slug (e.g. "pw"),
causing the alias-specific name block to fail its staleness check
and alternate on each input event. Fixed by skipping the generic
block for Alias inputs entirely — the alias block below handles naming.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* chore(bench): update e2e latency baseline [skip ci]
* chore(bench): update go tier1 baseline [skip ci]
* chore(bench): update frontend throughput baseline [skip ci]
* chore(demos): update E2E feature GIFs [skip ci]
* chore(sdd): planning artifacts for review-queue-jump-fix
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(review-queue): suppress auto-advance on session status transitions
The "deleted externally" effect in ReviewQueueContent used reviewQueueItems
(the filtered visible list) to check if the selected session still existed.
When a session transitioned to ACTIVE/PROCESSING, it was filtered from the
visible list but remained in the Redux store — the effect incorrectly fired
handleAutoAdvance(id, true), jumping to the next queue item immediately after
the user opened a session and clicked into the terminal.
Fix: use allQueueItems from useReviewQueueContext().items (the unfiltered
Redux store) as the existence oracle. A session filtered from the visible queue
due to status transition stays in the store and no longer triggers auto-advance.
Genuine removals (removeItem Redux events) still fire auto-advance correctly.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(sessions): prevent Claude process orphaning after server restart
Three-part fix for tmux session / Claude process accumulation:
**Fix 1 — DeleteSession fallback (session_service.go)**
When FindLiveInstance returns nil (e.g. server restarted since the session
was created, so the in-memory poller is empty), fall back to
KillTmuxSessionByTitle which kills by the deterministic tmux session name.
Previously the DB record was deleted but the Claude process kept running
indefinitely.
**Fix 2 — Startup orphan sweep (session/orphan_sweep.go)**
ReconcileOrphanedTmuxSessions runs as Step 6d of BuildRuntimeDeps, after
the re-adoption passes (6/6b) that hot-attach DB sessions to their live
tmux panes. It enumerates all staplersquad_* tmux sessions, reads the
STAPLER_SESSION_UUID env var from each, and kills any whose UUID (or
sanitized title) has no match in the current workspace DB. The keepalive
sentinel is always preserved.
**Fix 3 — MCPServerURL backfill (session_service.go)**
loadInstancesWithWiring now backfills inst.MCPServerURL from the server's
configured URL for sessions created before MCP integration was wired up.
Without this, buildLaunchCommand omits --mcp-config entirely and Claude
restarts without a session UUID, making it impossible to identify from the
process list or MCP request headers.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* chore(bench): update e2e latency baseline [skip ci]
* chore(bench): update go tier1 baseline [skip ci]
* chore(bench): update frontend throughput baseline [skip ci]
* fix(lint): return empty map instead of nil in GetAllInstanceArtifacts
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* chore(bench): update e2e latency baseline [skip ci]
* chore(bench): update go tier1 baseline [skip ci]
* chore(bench): update frontend throughput baseline [skip ci]
* fix(backlog): harden triage parser and add repoPath UI gate
ParseHeadlessTriageResult now uses brace-scan (strings.Index/LastIndex)
to tolerate natural-language preamble before the JSON block, fixing
silent parse failures on multi-step triage runs. The "Trigger Triage"
button in BacklogItemDetail and BacklogItemCard is now disabled with a
tooltip when repoPath is not set, preventing the confusing
CodeFailedPrecondition server error.
Adds 3 new unit tests for the parser and a Playwright e2e gate test
that creates an item without repoPath and asserts the button is
disabled.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* chore(demos): update E2E feature GIFs [skip ci]
* feat(harness): headless triage test harness + alias kebab-case fix
Adds a build-tagged Go harness (go:build harness) that exercises the
backlog triage feature end-to-end via the ConnectRPC HTTP layer with no
browser or UI. Four sub-tests cover distinct phases runnable individually:
Gate (repoPath precondition), TriggerAndPoll (async completion), ParserRobust
(preamble tolerance), and FullFlow (full user journey). Makefile targets
added for each phase.
Also converts alias namePrefix label to kebab-case lowercase
(spaces/underscores → hyphens) before concatenating with the prefix, so
"@SSQ My New Feature" produces "ssq-my-new-feature" instead of
"ssq-My New Feature". Two new tests added to Omnibar.alias.test.tsx.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* chore(sdd): planning artifacts for nav-redesign
Navigation redesign: group 16+ flat nav items into 4 sections (Work,
Automation, Insights, Settings & Tools), restore mobile access for 8
currently-hidden routes, and consolidate Settings/Config Files/Features.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(nav): group navigation into 4 sections, restore mobile access
Reorganise the 15 nav pages into Work / Automation / Insights / Settings
groups rendered in both DrawerNav (desktop sidebar) and BottomNav More
sheet (mobile). All 8 routes that were hidden from mobile (Settings,
Insights, Logs, Errors, Help, Escape Analytics, Files, Workflows/Rules)
are now reachable on every screen size. Removes the redundant Config
Files and Features top-level entries; fixes a DrawerNav bug where items
were shown regardless of feature-flag state.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* chore(bench): update e2e latency baseline [skip ci]
* chore(bench): update go tier1 baseline [skip ci]
* chore(bench): update frontend throughput baseline [skip ci]
* chore(demos): update E2E feature GIFs [skip ci]
* chore: commit in-progress work from previous sessions
Includes executor fixes (WithProcessDir support, Linux setsid/Setpgid
EPERM fix), backlog triage harness test expansions, rate-limit
integration test, Makefile test-triage-real target, and planning
artifacts for backlog-triage-e2e-hardening and
put-backlog-behind-a-feature-flag-by-default.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat: support Antigravity CLI hooks.json format in ssq-hooks
* fix(pane): restore session peek modal integration in pane picker
* feat(files): wire up the premium LocalFileBrowser component to the files page
* chore: commit in-progress work from previous sessions
- ssq-hooks: Antigravity CommandLine/Cwd normalization, workspace-aware
DB path resolution from cwd, WorkspacePaths fallback
- session service: ForkSession fully wired (callbacks, hook config,
controller, driver, autonomous mode); ResumeHibernated wires review
queue poller and autonomous driver
- ent schema: autonomous_mode bool field + generated ORM files
- instance_hibernate: start controller + session driver on resume
- omnibar: initialTitle prop pre-populates session name; OmnibarContext
threads title through openOmnibar(); page.tsx passes ?title param
- LocalFileBrowser: CSS and component updates
- scripts: find-orphaned-features.py, find-unmerged-commits.py
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(omnibar): replace Create shortcut hint with clickable Create Session button
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(settings): add UpsertAlias and DeleteAlias RPCs with AliasesManager UI
Implements full CRUD for alias session presets in Settings > General, removing
the need to manually edit config.json. Adds UpsertAlias/DeleteAlias ConnectRPC
handlers (case-insensitive name matching, slice-scan upsert, validation via
aliasNameRE) and a React AliasesManager component with inline 3-second delete
confirmation, env-var editor, tag management, and ARIA accessibility.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(registry): add alias RPCs to scanner methodToID map
UpsertAlias, DeleteAlias, ListAliases were missing from the methodToID
map, causing the scanner to use fallback raw-name IDs (UpsertAlias,
DeleteAlias, ListAliases) instead of canonical kebab-case IDs
(alias:upsert, alias:delete, alias:list). This caused Registry
Validation CI to fail with 3.36% divergence.
Removes the duplicate fallback JSON files from the registry root that
were generated under the old behavior.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(analytics): program detail panel with subcommand drill-down
Add DB-backed time-windowed analytics queries and an inline program
detail panel so operators can see exactly which sub-operations are
causing escalations before writing a rule.
Backend (Go):
- Add compound index on (command_program, created_at) to ent schema
- Replace full-table-scan ListAnalytics with time-windowed
ListAnalyticsSince (WHERE created_at >= ?) — AC-1, AC-2
- Add GetSubcommandBreakdown aggregation query using ent GroupBy — AC-4
- Add ListRecentCommandsByProgram returning last N command previews — AC-5
- Add GetSubcommandTrend returning per-day counts — AC-6
- Add GetProgramAnalytics ConnectRPC method returning SubcommandBreakdown,
ExampleCommands, RuleCoverage, DailyTrend — AC-7
Frontend (React/TypeScript):
- New ProgramDetailPanel component with subcommand frequency table
(count, %, decision breakdown), example commands, rule coverage
summary, trend sparklines, and "Add rule →" links — AC-8 through AC-13
- New useProgramAnalytics hook with AbortController cleanup
- ApprovalAnalyticsPanel: clicking program row opens inline detail panel
- ApprovalRulesPanel: fix panel crush in flex container (flexShrink: 0),
use window.location.search in useEffect for URL param pre-fill
(avoids useSearchParams/Suspense issues in Next.js static export)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(backlog): gate backlog behind feature flag on all layers
- Frontend layout guard: backlog/layout.tsx redirects to / when flag off
- Backend interceptor: FeatureFlagInterceptor wired to BacklogService only
- E2E tests: beforeAll/afterAll enable+restore the backlog flag
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: address copilot review comments on analytics drill-down
- Fix 1: exclude NULL command_subcategory rows in GetSubcommandBreakdown
to avoid sql.ScanSlice scan errors on nullable GROUP BY columns
- Fix 2: replace strings.Fields tokenizer in coveredSubcommands() with
regexp.Compile + synthetic "<program> <subcommand>" matching so
regex-style patterns (e.g. \bgit\b.*\bpush\b) work correctly
- Fix 3: add TestGetProgramAnalytics_ReturnsExpectedFields unit test
covering window_days=7 and non-nil response fields
- Fix 4: add escapeRegex() helper in ApprovalRulesPanel and use it when
prefilling commandPattern to avoid metacharacter injection; switch word
boundaries from \b to (?:^|\s)/(?:\s|$) for hyphenated program names
- Fix 5: add e.stopPropagation() on Suggest Rule button and "add manually"
link so clicking them does not toggle the parent <tr> drill-down row
- Fix 6: add tabIndex, role=button, aria-expanded, aria-label, and
onKeyDown (Enter/Space) to the clickable <tr> for keyboard accessibility
- Fix 7: call setData(null) before setIsLoading(false) in error path of
useProgramAnalytics to clear stale data on refresh failure
- Fix 8: render per-program daily trend sparkline in ProgramDetailPanel;
note that trend data is per-program not per-subcommand (backend limit)
- Fix 9: thread caller context through LoadProgramWindow,
GetSubcommandBreakdown, and ListRecentCommands instead of context.Background()
* fix(review-queue): resolve UUID→Title before Remove so approved/deleted sessions leave the queue
Queue items are keyed by inst.Title but approval-response and session-deleted
events arrive with UUID. resolveQueueKey() looks up the instance via FindInstance
(which handles both UUID and Title) and returns Title, falling back to the raw
value if the instance is no longer loaded.
Also removes duplicate SubcommandDecisionCount declaration in repository.go
introduced by the analytics cherry-pick merge.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* chore(bench): update go tier1 baseline [skip ci]
* fix(web): resolve post-merge TypeScript and lint errors
- ApprovalAnalyticsPanel: add missing imports (useGenerateRule, SuggestionSource,
addRuleManualLink) and state (activeRowKey, generateLoading, isGenerating)
for the 'Suggest Rule' button in the programs coverage-gap table
- ApprovalRulesPanel: restore missing RuleFormState interface, emptyForm constant,
useEffect/useRef imports, and URL-param pre-fill state aliases that were
dropped during the merge resolution
- feature_flag_interceptor_test: fix nilnil lint violation by returning a
non-nil connect.Response instead of (nil, nil)
* fix(web): resolve all 102 pre-existing test failures (2811/2811 pass)
jest.setup.js: add global stubs for window.matchMedia, next/navigation,
@xterm/addon-serialize, useAvailablePrograms, and useSlashCommands so
jsdom-based tests don't fail at module load time.
Source fixes:
- ApprovalRulesPanel: replace inline form with dialog modal; add
add-rule-button testid, Escape handler, second useGenerateRule instance
for cmd-sample generation, URL-param prefill via RuleBuilderPrefill
- ApprovalAnalyticsPanel: add Suggest Rule buttons + inline suggestion cards
to the uncovered-tools table (data-testid: suggest-rule-tool-{toolName})
- RuleBuilderForm: add testids for all form fields, advanced-regex-separator,
generate-from-command-details, command-sample sections; add cmdSuggestions
and cmdClear props
- OmnibarCreationPanel: update hint to 'typed into the session terminal'
- XtermTerminal: optional-chain terminal.element, attachCustomKeyEventHandler,
onScroll, onWriteParsed, and Disposable.dispose() for mock environments
- SubStatusChip: guard switch on undefined/null subStatus
- NotificationContext/ThemeContext: return no-op fallback outside Provider
- useShells: guard createAuthInterceptor in test environments
- SessionActionsOverflow: call onClearConversationState directly (no dialog)
- OmnibarResultList/QuickOpenPalette: guard scrollIntoView calls
- useAvailablePrograms: guard fetch in jest.fn() environments
- SessionCard: fix truncateGoal max to produce correct char count
- ruleBuilderPrefill: add commandPattern, initialName, isAiGenerated fields
* chore: update feature registry after merge
make registry-generate removes stale get-program-analytics entry that
was superseded during the fork→upstream sync.
---------
Co-authored-by: Tyler Stapler <tystapler@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 7 findings from a dedicated two-agent architecture review of the GitHub backlog sync feature (PR #138) and the execution-phase prompt driver, run after those areas had already shipped/closed. Filed as gap #10 in
project_plans/backlog-cross-platform-audit/gaps-and-risks.md; this PR fixes and closes it.Execution-phase prompt driver:
Instance.Prompt/Instance.InitialPromptdoc comments (and the matching proto comments) so the CLI-arg vs tmux-typed delivery mechanisms are no longer near-duplicate one-liners.SpawnSessionFromItemnow writes slash-commands/context file before spawning the session (newsession.EnsureDirectorySessionPathhelper), eliminating a race against the just-started claude process instead of relying on startup latency.WriteBacklogContextFilenow carriespriorSessionsand the plan-artifacts line consistently with the live CLI prompt, so the on-disk fallback the agent re-reads after context compaction doesn't lose history.Backlog sync feature, end-to-end:
UpdateFeatureFlagnow rolls back the persisted disk flag and returns an error if the controller toggle fails, instead of silently diverging disk/in-memory state.GitHubPRsPlugin.Fetchnow fetches CI labels via a boundederrgroup(concurrency 5) instead of serially, avoiding a timeout on repos with many open PRs.BacklogSourcesSettings.tsx's source-creation form is now driven by a per-plugin field schema instead of hardcoded owner/repo fields.GetSyncHistorynow reports atruncatedflag (new proto field) when history is capped at 200, surfaced as an inline UI notice.Test plan
go build ./...,go vet ./...cleango test ./session/... ./server/... -raceall greennpx tsc --noEmitcleanSessionCardAnalyticsContextProviderfailures already confirmed present on cleanmain)🤖 Generated with Claude Code