Cover Shift+Tab tab-reversal and fallback focus navigation when tab bindings are removed#136
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/9193e7a8-0e8b-4421-912c-25b71236b444 Co-authored-by: tig <585482+tig@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Shift-Tab functionality for unindenting rows
Cover Shift+Tab tab-reversal and fallback focus navigation when tab bindings are removed
May 15, 2026
tig
marked this pull request as ready for review
May 16, 2026 22:51
tig
added a commit
that referenced
this pull request
May 17, 2026
Reconciles develop's ted settings-UI port (#123) + indent fixes (#136) with Phase 2's removal of Editor.UseThemeBackground. UseThemeBackground is fully retired from the ted demo (the Editor knob is gone; theme decides bg): - TedApp.cs: dropped the Editor init flag, the "Use Theme Background" checkbox + its View-menu item, and the SaveViewSettings write-back; re-applied the Phase 2 Theme status-bar shortcut on top of develop's restructured ctor. - EditorSettings.cs: removed the UseThemeBackground persisted setting (property + ReadBool load + JSON serialize). - TedApp.MarkdownPreview.cs: Markdown preview no longer seeds UseThemeBackground from the removed Editor property (TG default). - Dropped the now-invalid Constructor_Defaults_UseThemeBackground_To_True test and the EditorSettings.UseThemeBackground reset. Verified against a local TG #5313 pack: 0 warnings/0 errors, Tests 439/439, IntegrationTests 190/190, dotnet format clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue asks for two guarantees: Shift+Tab should undo a prior Tab indent (including block indent/unindent behavior), and removing Tab bindings should restore normal Terminal.Gui view navigation.
This PR adds targeted integration coverage for both behaviors.
Tab/Shift+Tab regression coverage
Tabfollowed byShift+Tabon the current line to ensure indent insertion is reversed cleanly.Keybinding-removal navigation coverage
Key.Tabbinding and assert focus advances to the next control.Key.Tab.WithShiftbinding and assert focus moves to the previous control.TextField -> Editor -> TextFieldto validate default View focus traversal when editor-specific bindings are absent.Illustrative test shape
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.jetbrains.com/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.unix.runtimeconfig.json /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.exe Terminal.Gui.Editor.slnx --profile=TG.Editor Full Cleanup(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.unix.runtimeconfig.json /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.exe Terminal.Gui.Editor.slnx(dns block)If you need me to access, download, or install something from one of these locations, you can either: