Skip to content

Include package license and readme in NuGet outputs#72

Merged
tig merged 2 commits into
developfrom
copilot/fix-release-workflow-failure
May 12, 2026
Merged

Include package license and readme in NuGet outputs#72
tig merged 2 commits into
developfrom
copilot/fix-release-workflow-failure

Conversation

Copilot AI commented May 11, 2026

Copy link
Copy Markdown
Contributor

The v2.1.1-develop.54 release failed during dotnet pack because package metadata referenced LICENSE, but the file was not included in the generated NuGet package.

  • Package metadata
    • Adds root LICENSE and README.md to all packed projects from Directory.Build.props.
    • Keeps the shared package metadata centralized for both Terminal.Gui.Text and Terminal.Gui.Editor.
<ItemGroup>
  <None Include="$(MSBuildThisFileDirectory)LICENSE" Pack="true" PackagePath="" />
  <None Include="$(MSBuildThisFileDirectory)README.md" Pack="true" PackagePath="" />
</ItemGroup>

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.jetbrains.com
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2025.2.4/tools/netcoreapp3.1/any/cleanupcode.unix.runtimeconfig.json /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2025.2.4/tools/netcoreapp3.1/any/cleanupcode.exe Terminal.Gui.Text.slnx --profile=Built-in: Full Cleanup --no-build --exclude=third_party/**/* (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI assigned Copilot and tig May 11, 2026
Copilot AI linked an issue May 11, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix release workflow failure for v2.1.1-develop.54 Include package license and readme in NuGet outputs May 11, 2026
Copilot AI requested a review from tig May 11, 2026 23:52
Copilot finished work on behalf of tig May 11, 2026 23:52
@tig

tig commented May 12, 2026

Copy link
Copy Markdown
Member

@copilot do you know this is the cause for sure or are you guessing. This is the 4th of these failures I've assigned to you and you continue to not fix the problem.

Copilot AI commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot do you know this is the cause for sure or are you guessing. This is the 4th of these failures I've assigned to you and you continue to not fix the problem.

This one is confirmed, not a guess. The failed run’s pack-and-publish job failed specifically at Pack Terminal.Gui.Text with NU5030: The license file 'LICENSE' does not exist in the package. I reproduced that same dotnet pack src/Terminal.Gui.Text -c Release -p:Version=2.1.1-develop.54 failure locally before the change, and after commit 1e2b586 the same pack command succeeds. No UI changes.

Copilot finished work on behalf of tig May 12, 2026 00:25
@tig
tig marked this pull request as ready for review May 12, 2026 00:28
@tig
tig merged commit 92e0d46 into develop May 12, 2026
7 checks passed
@tig
tig deleted the copilot/fix-release-workflow-failure branch May 12, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release v2.1.1-develop.54 failed

2 participants