feat: move FileSystemTestingTrait to a new library product FileSystemTesting - #126
Merged
Conversation
fortmarek
force-pushed
the
file-system-testing
branch
from
May 15, 2025 11:11
ef55956 to
e91aab5
Compare
6 tasks
pepicrft
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new trait doesn't play nicely with the
--experimental-dump-helpfrom ArgumentParser that we use intuist/tuistbecause of theimport Testing– unfortunately, even the compiler directive#if canImport(Testing)doesn't lead to a successful generation of the dump help.To fix the issue, I'm moving the trait to a
FileSystemTestinglibrary. That way consumers can import this library if they are interested in using the trait but the core package stays without any testing-specific code.