fix: use FileManager for file and directory removal to fix performance issues - #85
Merged
Conversation
fortmarek
force-pushed
the
fix/remove-performance
branch
from
November 7, 2024 11:32
18c6a02 to
1b3e595
Compare
fortmarek
changed the title
fortmarek
force-pushed
the
fix/remove-performance
branch
from
November 7, 2024 11:34
1b3e595 to
8785787
Compare
fortmarek
commented
Nov 7, 2024
Comment on lines
-81
to
-85
| /// It removes the file or directory at the given path. | ||
| /// - Parameters: | ||
| /// - path: The path to the file or directory to remove. | ||
| /// - recursively: When removing a directory, it removes the sub-directories recursively. | ||
| func remove(_ path: AbsolutePath, recursively: Bool) async throws |
Member
Author
There was a problem hiding this comment.
FileManager doesn't have a distinction for a recursive removal – and it's not something we're using in tuist/tuist
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As flagged in apple/swift-nio#2933, the
NIOFileSystemremoval performance is abysmal. Ideally, we'd do a fix inswift-nio, but for now, the quicker solution is to move toFileManager.