Skip to content

Fix the reference length - #477

Merged
pepicrft merged 1 commit into
masterfrom
fix-tests
Sep 17, 2019
Merged

Fix the reference length#477
pepicrft merged 1 commit into
masterfrom
fix-tests

Conversation

@pepicrft

Copy link
Copy Markdown
Contributor

Short description 📝

This commit introduced a regression that caused the tests to fail because the generated object reference is 25 characters long instead of 24.

This PR fixes it.

@pepicrft
pepicrft requested review from a team and giginet September 17, 2019 16:16
@pepicrft pepicrft self-assigned this Sep 17, 2019
@codecov

codecov Bot commented Sep 17, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@f87362c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #477   +/-   ##
=========================================
  Coverage          ?   82.53%           
=========================================
  Files             ?      148           
  Lines             ?     8043           
  Branches          ?        0           
=========================================
  Hits              ?     6638           
  Misses            ?     1405           
  Partials          ?        0
Impacted Files Coverage Δ
Sources/XcodeProj/Utils/ReferenceGenerator.swift 86.43% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87362c...e4d3334. Read the comment docs.

@pepicrft
pepicrft merged commit 368fb87 into master Sep 17, 2019
@pepicrft
pepicrft deleted the fix-tests branch September 17, 2019 16:39
@giginet

giginet commented Sep 17, 2019

Copy link
Copy Markdown
Contributor

This issue caused by #474 😞

We should use ClosedRange instead of changing the test case.

String(reference[..<reference.index(reference.startIndex, offsetBy: 24)])

@pepicrft

Copy link
Copy Markdown
Contributor Author

We should use ClosedRange instead of changing the test case.

Feel free to open a PR with that suggestion 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants