[pull] master from php:master - #1175
Merged
Merged
Conversation
* PHP-8.2: Upgrade php-sdk to 2.8.2 (#23193)
* PHP-8.3: Upgrade php-sdk to 2.8.2 (#23193)
* PHP-8.4: Upgrade php-sdk to 2.8.2 (#23193)
* PHP-8.5: Upgrade php-sdk to 2.8.2 (#23193)
Runs the test suite in parallel by default; automatically selects up to 10 workers. Explicit -j1 remains the opt-out to run tests serial. Smaller batches improve balancing.
php_array_walk() recurses once per nesting level with no stack check, so array_walk_recursive() on a deeply nested array exhausts the native stack and the process dies with a segfault. This adds the same stack limit check ext/standard already uses in var.c and http.c, so the call throws an Error instead of crashing. The existing GC_IS_RECURSIVE guard only covers self-referential arrays, not plain deep nesting. Fixes GH-23111
php_array_replace_recursive() recurses once per nesting level with no stack check, so array_replace_recursive() on a deeply nested array exhausts the native stack and the process dies with a segfault. Fixes GH-23113
php_compact_var() recurses once per nesting level with no stack check, so passing a deeply nested array to compact() exhausts the native stack and the process dies with a segfault. This adds the same stack limit check ext/standard already uses in var.c and http.c, so the call throws an Error instead of crashing. Fixes GH-23115
* PHP-8.4: Add a stack limit check in php_compact_var() (#23126)
* PHP-8.5: Add a stack limit check in php_compact_var() (#23126)
pdo_raise_impl_error stored the SQLSTATE then still emitted E_WARNING even when the handle error mode was SILENT. The early return for SILENT was present but disabled (#if 0). Copy the error code first so errorInfo() remains valid, then return without warning. Closes GH-23070
It is only used once internally by zend_execute.c, as shown by a SourceGraph search. [1] [1] https://sourcegraph.com/search?q=context:global+-f:zend_execute.c+-f:zend_execute.h+zend_unfinished_calls_gc&patternType=keyword&sm=0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )