[pull] master from php:master - #1177
Merged
Merged
Conversation
touch_variation5-win32.phpt and touch_variation6-win32.phpt write to the same file, causing a race.
* PHP-8.4: Fix test file conflict
* PHP-8.5: Fix test file conflict
RFC: https://wiki.php.net/rfc/closure-optimizations#stateless_closure_caching Extracted from GH-19941. Sadly, @DanielEScherzer discovered an edge-case I did not consider: class Foo { public function instanceCall() { return $this; } public function test($c) { return array_map($c, [1]); } } $foo = new Foo(); var_dump($foo->test('Foo::instanceCall')); Here, the internal function array_map() can perform instance calls through a previous stack frame with just a named closure. Same with ['Foo', 'instanceCall']. That's quite esoteric, but this behavior should first be deprecated and removed before assuming it isn't being used. For the time being, merge only the latter half of the RFC. Code with all relevant functions properly annotated as static will get the full performance benefit. Closes GH-23203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )