[pull] master from php:master - #1182
Merged
Merged
Conversation
* PHP-8.5: ext/readline: Fixed the interactive shell not waiting for the pager process to exit (#23047)
* PHP-8.4: Fix test file conflict on Windows (#23226)
* PHP-8.5: Fix test file conflict on Windows (#23226)
The DO_INIT guard in zend_generator_resume() that avoids re-advancing an already-primed delegate read the flag on orig_generator, but in a nested "yield from" chain the fresh delegation is established by a middle generator rather than the outermost consumer. Track the delegating generator through the resume loop and check its DO_INIT, so a primed inner generator reached through two "yield from" levels yields its current value once instead of skipping it. Fixes GH-15375 Closes GH-22640
* PHP-8.4: Fix GH-15375: nested "yield from" skips items after valid()/next()
* PHP-8.5: Fix GH-15375: nested "yield from" skips items after valid()/next()
Closure::__invoke is documented and reachable via method_exists() and ReflectionClass (getMethod, hasMethod, getMethods), but get_class_methods() walks ce->function_table directly and Closure does not register __invoke there: the parameter list is materialized per-instance by zend_get_closure_invoke_method(). Append __invoke to the result when ce == zend_ce_closure, the same predicate is_closure_invoke() already uses in ext/reflection. Closes GH-17126
…er (#23220) Co-authored-by: Weilin Du <weilindu@php.net>
This function is only used once internally, and no usage is reported from a SourceGraph search. [1] [1] https://sourcegraph.com/search?q=context:global+-f:zend_API.c+-f:zend_API.h+zend_is_countable&patternType=keyword&sm=0
Both are single-argument wrappers around zend_string_tolower/upper; static analyzers and general string handling call them at very high frequency. The frameless call convention removes the call frame setup and argument copying. Co-authored-by: Markus Staab <maggus.staab@googlemail.com> Closes GH-23084
…hell (#23218) Reference: #22994 (comment) php -a class constant completion passed the full ClassName::PREFIX string to the constant completion generator. And textlen had already been shortened to the part after "::". This commit fixes this bug. Co-authored-by: Ilia Alshanetsky <ilia@ilia.ws>
* PHP-8.4: ext/readline: Fix class constant completion in readline interactive shell (#23218)
* PHP-8.5: ext/readline: Fix class constant completion in readline interactive shell (#23218)
* PHP-8.4: [skip ci] Fix NEWS entries in #23218
* PHP-8.5: [skip ci] Fix NEWS entries in #23218
… objects `ReflectionMethod::invoke()` and `::invokeArgs()` are affected, but share implementation code and so are updated together. https://wiki.php.net/rfc/deprecations_php_8_6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )