[pull] master from php:master - #1241
Merged
Merged
Conversation
Not sure how backdated NEWS will be useful, but this does add the note in UPGRADING which does matter. Per #12276 (comment)
Per 4f02d15. Since similar changes to zip_entry_close and header_register_callback has already been documented, this also should be documented.
…taining NUL bytes A ValueError is indeed thrown after this case.
Use zend_hash_sort_ex() directly for single-element arrays to avoid unpacking packed arrays and temporarily increasing the array refcount when the comparator cannot be invoked anyway. Keep the existing renumbering behavior for sort()-style operations and add behavioral tests covering single-element sorting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )