[pull] master from php:master#819
Merged
pull[bot] merged 4 commits intoturkdevops:masterfrom Mar 27, 2026
Merged
Conversation
When libphp.so (from the embed SAPI, or the apache module) is loaded
by another project that already uses libmagic, the symbols from the
two copies of libmagic...
$ objdump -TC ./libs/libphp.so | grep '\smagic_'
00000000002b2754 g DF .text 0000000000000034 Base magic_compile
00000000002b25fe g DF .text 0000000000000024 Base magic_open
00000000002b27f0 g DF .text 0000000000000034 Base magic_descriptor
00000000002b2720 g DF .text 0000000000000034 Base magic_load
00000000002b2c1a g DF .text 0000000000000032 Base magic_setflags
00000000002b27bc g DF .text 0000000000000034 Base magic_list
00000000002b2c62 g DF .text 0000000000000206 Base magic_setparam
00000000002b2bf4 g DF .text 0000000000000026 Base magic_getflags
00000000002b2bbe g DF .text 0000000000000036 Base magic_errno
00000000002b2e68 g DF .text 00000000000001f4 Base magic_getparam
00000000002b2b14 g DF .text 000000000000006e Base magic_buffer
00000000002b2b82 g DF .text 000000000000003c Base magic_error
00000000002b2788 g DF .text 0000000000000034 Base magic_check
00000000002b2c4c g DF .text 0000000000000016 Base magic_version
00000000002b26fa g DF .text 0000000000000026 Base magic_close
00000000002b2858 g DF .text 0000000000000034 Base magic_stream
00000000002b2824 g DF .text 0000000000000034 Base magic_file
can clash. To see this, we (pointlessly) link libphp.so from the
embed SAPI into a small program using the system copy of libmagic:
$ gcc $(/usr/lib/php8.5/bin/php-config --includes) main.c \
-L/usr/lib/php8.5/lib -lphp -lmagic
$ LD_LIBRARY_PATH=/usr/lib/php8.5/lib ./a.out
Segmentation fault LD_LIBRARY_PATH=/usr/lib/php8.5/lib ./a.out
To avoid this, we modify the internal "file_public" macro used by
libmagic, so that (on platforms that support it) hidden visibility is
used instead of the default. Afterwards the objdump command above
produces no output, and the test program no longer sefaults.
Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
PHP-bug: https://bugs.php.net/bug.php?id=66095
Gentoo-bug: https://bugs.gentoo.org/471682
Fixes #66095
Closes GH-21472
> Uncaught Error: Cannot indirectly modify readonly property ClassInfo::$constInfos in gen_stub.php:4158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )