[pull] master from ruby:master#1013
Merged
Merged
Conversation
Co-authored-by: Jean Boussier <byroot@ruby-lang.org>
../../../ext/digest/digest.c: In function ‘get_digest_base_metadata’:
../../../ext/digest/digest.c:587:12: warning: ‘obj’ may be used uninitialized [-Wmaybe-uninitialized]
587 | algo = get_metadata_ptr(obj);
| ^~~~~~~~~~~~~~~~~~~~~
../../../ext/digest/digest.c:574:11: note: ‘obj’ was declared here
574 | VALUE obj;
| ^~~
ruby/digest@edaafc2157
FL_TEST -> FL_TEST_RAW FL_SET -> FL_SET_RAW I was seeing bad performance on the ruby-bench getivar-module benchmark when using yjit. This was with other changes in a branch, but changes totally unrelated to accessing ivars on a class or using boxes. The change to RCLASS_PRIME_CLASSEXT_WRITABLE_P was the one that made the difference, but I changed a couple of other FL_SET uses as well. This change reduced the benchmark runs from 60ms to 40ms.
* The newly-released Ruby 4.0.4 fails that spec otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )